| Message ID | 20220623140507.626062-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] drm/logicvc: Fix error return code in logicvc_layer_init() | expand |
Hi Yang, On Thu 23 Jun 22, 22:05, Yang Yingliang wrote: > Fix error return code when logicvc_layer_formats_lookup() fails. > > Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Good catch! Yet Dan submitted a similar fix earlier, which is already on its way to the tree. Thanks! Paul > --- > drivers/gpu/drm/logicvc/logicvc_layer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c > index fbebe966f93a..54b5931d879f 100644 > --- a/drivers/gpu/drm/logicvc/logicvc_layer.c > +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c > @@ -489,6 +489,7 @@ static int logicvc_layer_init(struct logicvc_drm *logicvc, > > formats = logicvc_layer_formats_lookup(layer); > if (!formats) { > + ret = -EINVAL; > drm_err(drm_dev, "Failed to lookup formats for layer #%d\n", > index); > goto error; > -- > 2.25.1 >
diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c index fbebe966f93a..54b5931d879f 100644 --- a/drivers/gpu/drm/logicvc/logicvc_layer.c +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c @@ -489,6 +489,7 @@ static int logicvc_layer_init(struct logicvc_drm *logicvc, formats = logicvc_layer_formats_lookup(layer); if (!formats) { + ret = -EINVAL; drm_err(drm_dev, "Failed to lookup formats for layer #%d\n", index); goto error;
Fix error return code when logicvc_layer_formats_lookup() fails. Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/gpu/drm/logicvc/logicvc_layer.c | 1 + 1 file changed, 1 insertion(+)