| Message ID | 20220707021143.306926-1-windhl@126.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge:tc358767: Add of_node_put() when breaking out of loop | expand |
Can you use the norma commitl title prefix "drm/bridge: tc358767: " On Thu, 7 Jul 2022 at 04:45, Liang He <windhl@126.com> wrote: > > In tc_probe_bridge_endpoint(), we should call of_node_put() when > breaking out of the for_each_endpoint_of_node() which will automatically > increase and decrease the refcount. > > Fixes: 71f7d9c03118 ("drm/bridge: tc358767: Detect bridge mode from connected endpoints in DT") > Signed-off-by: Liang He <windhl@126.com> > --- > drivers/gpu/drm/bridge/tc358767.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c > index 485717c8f0b4..7362a1a7a7df 100644 > --- a/drivers/gpu/drm/bridge/tc358767.c > +++ b/drivers/gpu/drm/bridge/tc358767.c > @@ -1986,8 +1986,10 @@ static int tc_probe_bridge_endpoint(struct tc_data *tc) > > for_each_endpoint_of_node(dev->of_node, node) { > of_graph_parse_endpoint(node, &endpoint); > - if (endpoint.port > 2) > + if (endpoint.port > 2) { > + of_node_put(node); > return -EINVAL; > + } > > mode |= BIT(endpoint.port); > } > -- > 2.25.1 > Please resend a v2 with the above change. Reviewed-by: Robert Foss <robert.foss@linaro.org>
diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 485717c8f0b4..7362a1a7a7df 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -1986,8 +1986,10 @@ static int tc_probe_bridge_endpoint(struct tc_data *tc) for_each_endpoint_of_node(dev->of_node, node) { of_graph_parse_endpoint(node, &endpoint); - if (endpoint.port > 2) + if (endpoint.port > 2) { + of_node_put(node); return -EINVAL; + } mode |= BIT(endpoint.port); }
In tc_probe_bridge_endpoint(), we should call of_node_put() when breaking out of the for_each_endpoint_of_node() which will automatically increase and decrease the refcount. Fixes: 71f7d9c03118 ("drm/bridge: tc358767: Detect bridge mode from connected endpoints in DT") Signed-off-by: Liang He <windhl@126.com> --- drivers/gpu/drm/bridge/tc358767.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)