From patchwork Fri Jul 8 09:56:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 12910854 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3543C433EF for ; Fri, 8 Jul 2022 09:59:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C7353113816; Fri, 8 Jul 2022 09:57:51 +0000 (UTC) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF770113827 for ; Fri, 8 Jul 2022 09:57:50 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id B593F32009AA; Fri, 8 Jul 2022 05:57:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 08 Jul 2022 05:57:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1657274269; x=1657360669; bh=Dr DT0t2/NlF+LRhNyEhpBFJHuuhe2PjExpzKWhtzaLE=; b=bHaYmtJ6ZqaZz8/U5Q EOxeK28VjisiYYowuHFVd+bCoTVLqJk2wbJenyLGDiIKegZ/fXHnYxKupngJ6GXn WMd+zzEfAtnruWl790AgCPWxFix2fZyt9nf2cpMxMC+350wLl6JdfA70O7QAuciO i2H3jcfG690kSFF66IktxvvVshml2TpDJTir4vlIxlwXOIGoEaAAm1jahi3Giwtc CzJmkQjjrK7GARTwHyI1d9NfCiHZfD+LtIOqUbHIkSKKnbPwZlPz+oW6DYLs7hnz +Hxx8LR8WpyBo3FfVQLD8xWDLKkn97lgCu8Ew0hXVTgYtnCkYSLaEwmS+xert07r nm/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1657274269; x=1657360669; bh=DrDT0t2/NlF+L RhNyEhpBFJHuuhe2PjExpzKWhtzaLE=; b=GOgAB6ZdlUIk/69fG95dDoXEU8nNr hTGl4zBl7jBGYmlE4RR4Kf2CQTBxQOfK/iyJu1b4RO8K0+A+ATRz3775mSUTd7X9 SvLwYZUjI5WvzzwPHf2Q387hyx/R5ooK8odapvOxaQxxTd5uArc6M9EqT+mUfkWV IYbWJ5YQuR4PuKPZc4oBLc2MVDFmCS1ePCmNeWHjghKZdPswZN7lKujLhJ0atTcr 3QvByftO4XBLEEMzEPbut+s4776Q+OMeAIoBdRunxxpHQrWi1iG9Gr7vzlV9ZiUt 1lFT/FGwdlS++2ZD82g8FjRwaHjlVMA3Orlo19GgO+t/qpnF8z/+rcaVw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeijedgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeelkeefteduhfekjeeihfetudfguedvveekkeetteekhfekhfdtlefgfedu vdejhfenucevlhhushhtvghrufhiiigvpeefnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Jul 2022 05:57:48 -0400 (EDT) From: Maxime Ripard To: Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard Subject: [PATCH v4 13/69] drm/vc4: drv: Use drm_dev_unplug Date: Fri, 8 Jul 2022 11:56:11 +0200 Message-Id: <20220708095707.257937-14-maxime@cerno.tech> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220708095707.257937-1-maxime@cerno.tech> References: <20220708095707.257937-1-maxime@cerno.tech> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" When our KMS driver is unbound, the device is no longer there but we might still have users with an opened fd to the KMS device. To avoid any issue in such a situation, every device access needs to be protected by calls to drm_dev_enter() and drm_dev_exit(), and the driver needs to call drm_dev_unplug(). We'll add calls to drm_dev_enter()/drm_dev_exit() in subsequent patches changing the relevant drivers, but let's start by calling drm_dev_unplug(). Acked-by: Thomas Zimmermann Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 6b8dfa1e7650..79a37d18aeb1 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.c +++ b/drivers/gpu/drm/vc4/vc4_drv.c @@ -399,8 +399,7 @@ static void vc4_drm_unbind(struct device *dev) { struct drm_device *drm = dev_get_drvdata(dev); - drm_dev_unregister(drm); - + drm_dev_unplug(drm); drm_atomic_helper_shutdown(drm); }