From patchwork Fri Jul 29 16:35:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 12932684 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 746AAC04A68 for ; Fri, 29 Jul 2022 16:48:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6D439113FB4; Fri, 29 Jul 2022 16:48:17 +0000 (UTC) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by gabe.freedesktop.org (Postfix) with ESMTPS id 534DF10F32C for ; Fri, 29 Jul 2022 16:45:48 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id BFCA6580980; Fri, 29 Jul 2022 12:36:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 29 Jul 2022 12:36:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1659112606; x= 1659119806; bh=F/VhzqSdix62l27XLYpBCO7aYppl/5mjESdrPRMdeMc=; b=R N2JuGdu18CHIuri+ZEN21A+gOWBanrWJAdBZfy8XN8R4Ow329APiorsMscoXqOQg eOE2YsLI6f7o8Gd2BCDy5z91TzE9qYxZEC0TWq0jLGQwoH6RO8LEXykeaf5LQ8e6 dPLTOimT/CkauHyzo+UQEkPHpVNGSM1C7d7UgqYM1tddzyHWKiORXq8TeC1ctdNG +GOvyTLQeBaTu6FTJXzL6wRQVPfWWapk3t9HuiPW8HCqgzYKRcidbeEBgMaXhrEi m6tQcF1Rt1+ac7omlnFCBrlnEIWrUQi698cVL822Ax7y5l42VUqo0UjHNX6zoxIv 5FNPH+uJjI/DfrvzYt+kg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1659112606; x= 1659119806; bh=F/VhzqSdix62l27XLYpBCO7aYppl/5mjESdrPRMdeMc=; b=z 4ueLWEyrH7WkXZUGIsik5MVqZNX+2HVLgIAEblLyKPrkk/8wzP8Ku5w0LvClM/Kq 5S+wwmxEdGspf/YGU4TJfKTFveMCX5mB4ufSiD+Wpg7otR+XedA1arkqjYTnlj7W JDOUTaMsbQRzU7rW/hqzvGWmM8k21by6o3iL93GU9ZEv6cv+YKKZShd6ln6YS0tS P/rSpkPaPLunXPJd4Hmb6up3wRS2R/Q8ost6sbTFzf5OwyByAeb2TroBUNPFwG+6 AgyQw6JImeocmGf5Ix4PnJo6Ne/evhdizBRXaQ0GmlbBoIGMTFdwOi5rtxoea70i UY7t25eF1qmwCoTJjwZQA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddujedguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfgggtoffgsehtkeertdertdejnecuhfhrohhmpefo rgigihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecugg ftrfgrthhtvghrnhepgfffgfetffduudelhfevieffffduleevgfegkeeutefgffejheel leekjeefhfejnecuvehluhhsthgvrhfuihiivgepheenucfrrghrrghmpehmrghilhhfrh homhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Jul 2022 12:36:45 -0400 (EDT) From: Maxime Ripard To: Jernej Skrabec , Martin Blumenstingl , Chen-Yu Tsai , Philipp Zabel , Jerome Brunet , Samuel Holland , Thomas Zimmermann , Daniel Vetter , Emma Anholt , David Airlie , Maarten Lankhorst , =?utf-8?q?Noralf_Tr?= =?utf-8?q?=C3=B8nnes?= , Kevin Hilman , Neil Armstrong , Maxime Ripard Subject: [PATCH v1 22/35] drm/vc4: vec: Use TV Reset implementation Date: Fri, 29 Jul 2022 18:35:05 +0200 Message-Id: <20220728-rpi-analog-tv-properties-v1-22-3d53ae722097@cerno.tech> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220728-rpi-analog-tv-properties-v1-0-3d53ae722097@cerno.tech> References: <20220728-rpi-analog-tv-properties-v1-0-3d53ae722097@cerno.tech> MIME-Version: 1.0 X-Mailer: b4 0.10.0-dev-49460 X-Developer-Signature: v=1; a=openpgp-sha256; l=1406; i=maxime@cerno.tech; h=from:subject:message-id; bh=2RWnJNFvJqSTsOQ2zvbFCwdfzkNymcZjtNpJxCcBkek=; b=owGbwMvMwCHc4XzqmfnC7acZT6slMSQ94VHyarC6xHSooKXyrvLmvZc77wnv4RNY+P+oe0HQp3XT nRzmdZSyMAhzMMiKKbJcF3xrxxcW5RbB82EzzBxWJpAhDFycAjCRGXkM/z0r68NfuC20lF0nu6tr62 opU9NUZQn9E6s7VlXdlDmh7sDwV+T79Zl3dwiu/WWotCiqwO6oxUc+myc2xiVPlzn4/fPWkwcA X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Mateusz Kwiatkowski , Geert Uytterhoeven , Maxime Ripard , linux-amlogic@lists.infradead.org, linux-sunxi@lists.linux.dev, Phil Elwell , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The analog TV properties created by the drm_mode_create_tv_properties() are not properly initialised at reset. Let's switch our implementation to call drm_atomic_helper_connector_tv_reset(). Signed-off-by: Maxime Ripard Reported-by: kernel test robot diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/drivers/gpu/drm/vc4/vc4_vec.c index fba15a14787e..6f4536bf537f 100644 --- a/drivers/gpu/drm/vc4/vc4_vec.c +++ b/drivers/gpu/drm/vc4/vc4_vec.c @@ -254,6 +254,12 @@ vc4_vec_connector_detect(struct drm_connector *connector, bool force) return connector_status_unknown; } +void vc4_vec_connector_reset(struct drm_connector *connector) +{ + drm_atomic_helper_connector_reset(connector); + drm_atomic_helper_connector_tv_reset(connector); +} + static int vc4_vec_connector_get_modes(struct drm_connector *connector) { struct drm_connector_state *state = connector->state; @@ -274,7 +280,7 @@ static int vc4_vec_connector_get_modes(struct drm_connector *connector) static const struct drm_connector_funcs vc4_vec_connector_funcs = { .detect = vc4_vec_connector_detect, .fill_modes = drm_helper_probe_single_connector_modes, - .reset = drm_atomic_helper_connector_reset, + .reset = vc4_vec_connector_reset, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, };