| Message ID | 20220728-rpi-analog-tv-properties-v1-31-3d53ae722097@cerno.tech (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Analog TV Improvements | expand |
Dne petek, 29. julij 2022 ob 18:35:14 CEST je Maxime Ripard napisal(a): > The reset line is deasserted at bind, and asserted if we ever encounter an > error there. However, it's never deasserted in unbind which will lead to a s/deasserted/asserted/ Once fixed: Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > resource unbalance. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c > b/drivers/gpu/drm/sun4i/sun4i_tv.c index ad6a3739bfa9..74ff5ad6a8b9 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_tv.c > +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c > @@ -605,6 +605,7 @@ static void sun4i_tv_unbind(struct device *dev, struct > device *master, drm_connector_cleanup(&tv->connector); > drm_encoder_cleanup(&tv->encoder); > clk_disable_unprepare(tv->clk); > + reset_control_assert(tv->reset); > } > > static const struct component_ops sun4i_tv_ops = {
diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c index ad6a3739bfa9..74ff5ad6a8b9 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tv.c +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c @@ -605,6 +605,7 @@ static void sun4i_tv_unbind(struct device *dev, struct device *master, drm_connector_cleanup(&tv->connector); drm_encoder_cleanup(&tv->encoder); clk_disable_unprepare(tv->clk); + reset_control_assert(tv->reset); } static const struct component_ops sun4i_tv_ops = {
The reset line is deasserted at bind, and asserted if we ever encounter an error there. However, it's never deasserted in unbind which will lead to a resource unbalance. Signed-off-by: Maxime Ripard <maxime@cerno.tech>