| Message ID | 20220730122342.146475-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/userptr: remove redundation assignment to variable ret | expand |
On Sat, Jul 30, 2022 at 01:23:42PM +0100, Colin Ian King wrote: >Variable ret is assigned a value that is never read; it is either >being re-assigned during the following while-loop or after the loop. >The assignmnt is redundant and can be removed. > >Cleans up clang scan build warning: >drivers/gpu/drm/i915/gem/i915_gem_userptr.c:295:11: warning: Although >the value stored to 'ret' is used in the enclosing expression, the >value is never actually read from 'ret' [deadcode.DeadStores] > >Signed-off-by: Colin Ian King <colin.i.king@gmail.com> >--- > drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c >index 8423df021b71..075aef875a07 100644 >--- a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c >+++ b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c >@@ -292,7 +292,7 @@ int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj) > if (!i915_gem_object_is_readonly(obj)) > gup_flags |= FOLL_WRITE; > >- pinned = ret = 0; >+ pinned = 0; > while (pinned < num_pages) { > ret = pin_user_pages_fast(obj->userptr.ptr + pinned * PAGE_SIZE, > num_pages - pinned, gup_flags, LGTM. Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com> >-- >2.35.3 >
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c index 8423df021b71..075aef875a07 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c @@ -292,7 +292,7 @@ int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj) if (!i915_gem_object_is_readonly(obj)) gup_flags |= FOLL_WRITE; - pinned = ret = 0; + pinned = 0; while (pinned < num_pages) { ret = pin_user_pages_fast(obj->userptr.ptr + pinned * PAGE_SIZE, num_pages - pinned, gup_flags,
Variable ret is assigned a value that is never read; it is either being re-assigned during the following while-loop or after the loop. The assignmnt is redundant and can be removed. Cleans up clang scan build warning: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:295:11: warning: Although the value stored to 'ret' is used in the enclosing expression, the value is never actually read from 'ret' [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)