[v1] drm/panel: simple: set bpc field for logic technologies displays

Commit Message

Francesco Dolcini Aug. 31, 2022, 2:16 p.m. UTC

From: Aishwarya Kothari <[e-mail]>

In case bpc is not set for a panel it then throws a WARN(). Add bpc to
the panels logictechno_lt170410_2whc and logictechno_lt161010_2nh.

Fixes: 5728fe7fa539 ("drm/panel: simple: add display timings for logic technologies displays")
Signed-off-by: Aishwarya Kothari <[e-mail]>
Signed-off-by: Francesco Dolcini <[e-mail]>
---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Francesco Dolcini Oct. 17, 2022, 2:18 p.m. UTC | #1

On Wed, Aug 31, 2022 at 04:16:22PM +0200, Francesco Dolcini wrote:
> From: Aishwarya Kothari <[e-mail]>
> 
> In case bpc is not set for a panel it then throws a WARN(). Add bpc to
> the panels logictechno_lt170410_2whc and logictechno_lt161010_2nh.
> 
> Fixes: 5728fe7fa539 ("drm/panel: simple: add display timings for logic technologies displays")

Hello,
just a gently ping on this. It applies cleanly on v6.1-rc1, anything I
should do?

Francesco

Francesco Dolcini Nov. 10, 2022, 1:12 p.m. UTC | #2

On Mon, Oct 17, 2022 at 04:18:13PM +0200, Francesco Dolcini wrote:
> On Wed, Aug 31, 2022 at 04:16:22PM +0200, Francesco Dolcini wrote:
> > From: Aishwarya Kothari <[e-mail]>
> > 
> > In case bpc is not set for a panel it then throws a WARN(). Add bpc to
> > the panels logictechno_lt170410_2whc and logictechno_lt161010_2nh.
> > 
> > Fixes: 5728fe7fa539 ("drm/panel: simple: add display timings for logic technologies displays")
> 
> Hello,
> just a gently ping on this. It applies cleanly on v6.1-rc1, anything I
> should do?

Hello Doug,
can you help on this patch? I am not sure who is supposed to pick this
small fix, but it looks like you recently took patches on
"drm/panel: simple:", so maybe you can help.

Francesco

Doug Anderson Nov. 10, 2022, 3:32 p.m. UTC | #3

Hi,

On Thu, Nov 10, 2022 at 5:13 AM Francesco Dolcini <[e-mail]> wrote:
>
> On Mon, Oct 17, 2022 at 04:18:13PM +0200, Francesco Dolcini wrote:
> > On Wed, Aug 31, 2022 at 04:16:22PM +0200, Francesco Dolcini wrote:
> > > From: Aishwarya Kothari <[e-mail]>
> > >
> > > In case bpc is not set for a panel it then throws a WARN(). Add bpc to
> > > the panels logictechno_lt170410_2whc and logictechno_lt161010_2nh.
> > >
> > > Fixes: 5728fe7fa539 ("drm/panel: simple: add display timings for logic technologies displays")
> >
> > Hello,
> > just a gently ping on this. It applies cleanly on v6.1-rc1, anything I
> > should do?
>
> Hello Doug,
> can you help on this patch? I am not sure who is supposed to pick this
> small fix, but it looks like you recently took patches on
> "drm/panel: simple:", so maybe you can help.

Sure. It looks fine to me so I don't mind applying it. I did a quick
double-check and I was amused that the datasheet of the 800x480 screen
claims that it can show 16.7M colors with an 18-bit interface. ;-)

Pushed to drm-misc-fixes:

876153ab068b drm/panel: simple: set bpc field for logic technologies displays

Patch

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index ff5e1a44c43a..fef3fb0f45c9 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2505,6 +2505,7 @@  static const struct display_timing logictechno_lt161010_2nh_timing = {
 static const struct panel_desc logictechno_lt161010_2nh = {
 	.timings = &logictechno_lt161010_2nh_timing,
 	.num_timings = 1,
+	.bpc = 6,
 	.size = {
 		.width = 154,
 		.height = 86,
@@ -2534,6 +2535,7 @@  static const struct display_timing logictechno_lt170410_2whc_timing = {
 static const struct panel_desc logictechno_lt170410_2whc = {
 	.timings = &logictechno_lt170410_2whc_timing,
 	.num_timings = 1,
+	.bpc = 8,
 	.size = {
 		.width = 217,
 		.height = 136,