| Message ID | 20220902130105.139138-1-gregkh@linuxfoundation.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amd/display: fix memory leak when using debugfs_lookup() | expand |
On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote: > When calling debugfs_lookup() the result must have dput() called on it, > otherwise the memory will leak over time. Fix this up by properly > calling dput(). > > Cc: Harry Wentland <harry.wentland@amd.com> > Cc: Leo Li <sunpeng.li@amd.com> > Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Wayne Lin <Wayne.Lin@amd.com> > Cc: hersen wu <hersenxs.wu@amd.com> > Cc: Wenjing Liu <wenjing.liu@amd.com> > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > Cc: Thelford Williams <tdwilliamsiv@gmail.com> > Cc: Fangzhi Zuo <Jerry.Zuo@amd.com> > Cc: Yongzhi Liu <lyz_cs@pku.edu.cn> > Cc: Mikita Lipski <mikita.lipski@amd.com> > Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com> > Cc: Sean Paul <seanpaul@chromium.org> > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- Despite a zillion cc: items, I forgot to cc: stable on this. Can the maintainer add that here, or do you all want me to resend it with that item added? thanks, greg k-h
On 2022-09-02 09:10, Greg Kroah-Hartman wrote: > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote: >> When calling debugfs_lookup() the result must have dput() called on it, >> otherwise the memory will leak over time. Fix this up by properly >> calling dput(). >> >> Cc: Harry Wentland <harry.wentland@amd.com> >> Cc: Leo Li <sunpeng.li@amd.com> >> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> >> Cc: Alex Deucher <alexander.deucher@amd.com> >> Cc: "Christian König" <christian.koenig@amd.com> >> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com> >> Cc: David Airlie <airlied@linux.ie> >> Cc: Daniel Vetter <daniel@ffwll.ch> >> Cc: Wayne Lin <Wayne.Lin@amd.com> >> Cc: hersen wu <hersenxs.wu@amd.com> >> Cc: Wenjing Liu <wenjing.liu@amd.com> >> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> >> Cc: Thelford Williams <tdwilliamsiv@gmail.com> >> Cc: Fangzhi Zuo <Jerry.Zuo@amd.com> >> Cc: Yongzhi Liu <lyz_cs@pku.edu.cn> >> Cc: Mikita Lipski <mikita.lipski@amd.com> >> Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> >> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com> >> Cc: Sean Paul <seanpaul@chromium.org> >> Cc: amd-gfx@lists.freedesktop.org >> Cc: dri-devel@lists.freedesktop.org >> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> --- > > Despite a zillion cc: items, I forgot to cc: stable on this. Can the > maintainer add that here, or do you all want me to resend it with that > item added? > > thanks, > > greg k-h Hi Greg, Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> Is 'Cc: stable@vger.kernel.org' enough here? I can make this change before I merge it into amd-staging-drm-next. Thanks Siqueira
On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote: > > > On 2022-09-02 09:10, Greg Kroah-Hartman wrote: > > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote: > > > When calling debugfs_lookup() the result must have dput() called on it, > > > otherwise the memory will leak over time. Fix this up by properly > > > calling dput(). > > > > > > Cc: Harry Wentland <harry.wentland@amd.com> > > > Cc: Leo Li <sunpeng.li@amd.com> > > > Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> > > > Cc: Alex Deucher <alexander.deucher@amd.com> > > > Cc: "Christian König" <christian.koenig@amd.com> > > > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com> > > > Cc: David Airlie <airlied@linux.ie> > > > Cc: Daniel Vetter <daniel@ffwll.ch> > > > Cc: Wayne Lin <Wayne.Lin@amd.com> > > > Cc: hersen wu <hersenxs.wu@amd.com> > > > Cc: Wenjing Liu <wenjing.liu@amd.com> > > > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > > > Cc: Thelford Williams <tdwilliamsiv@gmail.com> > > > Cc: Fangzhi Zuo <Jerry.Zuo@amd.com> > > > Cc: Yongzhi Liu <lyz_cs@pku.edu.cn> > > > Cc: Mikita Lipski <mikita.lipski@amd.com> > > > Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > > > Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com> > > > Cc: Sean Paul <seanpaul@chromium.org> > > > Cc: amd-gfx@lists.freedesktop.org > > > Cc: dri-devel@lists.freedesktop.org > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > --- > > > > Despite a zillion cc: items, I forgot to cc: stable on this. Can the > > maintainer add that here, or do you all want me to resend it with that > > item added? > > > > thanks, > > > > greg k-h > > Hi Greg, > > Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> > > Is 'Cc: stable@vger.kernel.org' enough here? I can make this change before I > merge it into amd-staging-drm-next. Yes, please add the cc: stable@ line to the body of the patch, sorry I forgot that. thanks, greg k-h
On 2022-09-06 11:06, Greg Kroah-Hartman wrote: > On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote: >> >> >> On 2022-09-02 09:10, Greg Kroah-Hartman wrote: >>> On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote: >>>> When calling debugfs_lookup() the result must have dput() called on it, >>>> otherwise the memory will leak over time. Fix this up by properly >>>> calling dput(). >>>> >>>> Cc: Harry Wentland <harry.wentland@amd.com> >>>> Cc: Leo Li <sunpeng.li@amd.com> >>>> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> >>>> Cc: Alex Deucher <alexander.deucher@amd.com> >>>> Cc: "Christian König" <christian.koenig@amd.com> >>>> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com> >>>> Cc: David Airlie <airlied@linux.ie> >>>> Cc: Daniel Vetter <daniel@ffwll.ch> >>>> Cc: Wayne Lin <Wayne.Lin@amd.com> >>>> Cc: hersen wu <hersenxs.wu@amd.com> >>>> Cc: Wenjing Liu <wenjing.liu@amd.com> >>>> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> >>>> Cc: Thelford Williams <tdwilliamsiv@gmail.com> >>>> Cc: Fangzhi Zuo <Jerry.Zuo@amd.com> >>>> Cc: Yongzhi Liu <lyz_cs@pku.edu.cn> >>>> Cc: Mikita Lipski <mikita.lipski@amd.com> >>>> Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> >>>> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com> >>>> Cc: Sean Paul <seanpaul@chromium.org> >>>> Cc: amd-gfx@lists.freedesktop.org >>>> Cc: dri-devel@lists.freedesktop.org >>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >>>> --- >>> >>> Despite a zillion cc: items, I forgot to cc: stable on this. Can the >>> maintainer add that here, or do you all want me to resend it with that >>> item added? >>> >>> thanks, >>> >>> greg k-h >> >> Hi Greg, >> >> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> >> >> Is 'Cc: stable@vger.kernel.org' enough here? I can make this change before I >> merge it into amd-staging-drm-next. > > Yes, please add the cc: stable@ line to the body of the patch, sorry I > forgot that. > Change applied to amd-staging-drm-next, with the Cc to the stable branch. Thanks Siqueira > thanks, > > greg k-h
On Tue, Sep 06, 2022 at 11:39:44AM -0400, Rodrigo Siqueira Jordao wrote: > > > On 2022-09-06 11:06, Greg Kroah-Hartman wrote: > > On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote: > > > > > > > > > On 2022-09-02 09:10, Greg Kroah-Hartman wrote: > > > > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote: > > > > > When calling debugfs_lookup() the result must have dput() called on it, > > > > > otherwise the memory will leak over time. Fix this up by properly > > > > > calling dput(). > > > > > > > > > > Cc: Harry Wentland <harry.wentland@amd.com> > > > > > Cc: Leo Li <sunpeng.li@amd.com> > > > > > Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> > > > > > Cc: Alex Deucher <alexander.deucher@amd.com> > > > > > Cc: "Christian König" <christian.koenig@amd.com> > > > > > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com> > > > > > Cc: David Airlie <airlied@linux.ie> > > > > > Cc: Daniel Vetter <daniel@ffwll.ch> > > > > > Cc: Wayne Lin <Wayne.Lin@amd.com> > > > > > Cc: hersen wu <hersenxs.wu@amd.com> > > > > > Cc: Wenjing Liu <wenjing.liu@amd.com> > > > > > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > > > > > Cc: Thelford Williams <tdwilliamsiv@gmail.com> > > > > > Cc: Fangzhi Zuo <Jerry.Zuo@amd.com> > > > > > Cc: Yongzhi Liu <lyz_cs@pku.edu.cn> > > > > > Cc: Mikita Lipski <mikita.lipski@amd.com> > > > > > Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > > > > > Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com> > > > > > Cc: Sean Paul <seanpaul@chromium.org> > > > > > Cc: amd-gfx@lists.freedesktop.org > > > > > Cc: dri-devel@lists.freedesktop.org > > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > > --- > > > > > > > > Despite a zillion cc: items, I forgot to cc: stable on this. Can the > > > > maintainer add that here, or do you all want me to resend it with that > > > > item added? > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > Hi Greg, > > > > > > Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> > > > > > > Is 'Cc: stable@vger.kernel.org' enough here? I can make this change before I > > > merge it into amd-staging-drm-next. > > > > Yes, please add the cc: stable@ line to the body of the patch, sorry I > > forgot that. > > > > Change applied to amd-staging-drm-next, with the Cc to the stable branch. Wonderful, thanks!
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c index 0e48824f55e3..ee242d9d8b06 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c @@ -3288,6 +3288,7 @@ void crtc_debugfs_init(struct drm_crtc *crtc) &crc_win_y_end_fops); debugfs_create_file_unsafe("crc_win_update", 0644, dir, crtc, &crc_win_update_fops); + dput(dir); #endif debugfs_create_file("amdgpu_current_bpc", 0644, crtc->debugfs_entry, crtc, &amdgpu_current_bpc_fops);
When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. Fix this up by properly calling dput(). Cc: Harry Wentland <harry.wentland@amd.com> Cc: Leo Li <sunpeng.li@amd.com> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: "Christian König" <christian.koenig@amd.com> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Wayne Lin <Wayne.Lin@amd.com> Cc: hersen wu <hersenxs.wu@amd.com> Cc: Wenjing Liu <wenjing.liu@amd.com> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> Cc: Thelford Williams <tdwilliamsiv@gmail.com> Cc: Fangzhi Zuo <Jerry.Zuo@amd.com> Cc: Yongzhi Liu <lyz_cs@pku.edu.cn> Cc: Mikita Lipski <mikita.lipski@amd.com> Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com> Cc: Sean Paul <seanpaul@chromium.org> Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 1 + 1 file changed, 1 insertion(+)