| Message ID | 20220905184711.391022-1-michal.winiarski@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/doc: Custom Kconfig for KUnit is no longer needed | expand |
On 9/6/22 01:47, Michał Winiarski wrote:
> References: commit 6fc3a8636a7b ("kunit: tool: Enable virtio/PCI by default on UML")
Use Fixes: tag for bugfix patches instead.
On Tue, Sep 06, 2022 at 08:37:00AM +0700, Bagas Sanjaya wrote: > On 9/6/22 01:47, Michał Winiarski wrote: > > References: commit 6fc3a8636a7b ("kunit: tool: Enable virtio/PCI by default on UML") > > Use Fixes: tag for bugfix patches instead. Can documentation update (when the referenced patch didn't touch the docs) really be treated as a bugfix? Or is it just a reference, validating the reasoning behind this patch? -Michał > > -- > An old man doll... just what I always wanted! - Clara
Michał Winiarski <michal.winiarski@intel.com> writes: > On Tue, Sep 06, 2022 at 08:37:00AM +0700, Bagas Sanjaya wrote: >> On 9/6/22 01:47, Michał Winiarski wrote: >> > References: commit 6fc3a8636a7b ("kunit: tool: Enable virtio/PCI by default on UML") >> >> Use Fixes: tag for bugfix patches instead. > > Can documentation update (when the referenced patch didn't touch the docs) > really be treated as a bugfix? > Or is it just a reference, validating the reasoning behind this patch? I kind of agree; I'm not sure that a Fixes tag is really warranted here. Thanks, jon
Hi Michał, On Mon, Sep 05, 2022 at 08:47:11PM +0200, Michał Winiarski wrote: > When built for UML, KUnit provides virtio/PCI, which means that the > DMA/IOMEM UML emulation needed by DRM is already present and does not > need to be manually added with --kconfig_add. > > References: commit 6fc3a8636a7b ("kunit: tool: Enable virtio/PCI by default on UML") > Signed-off-by: Michał Winiarski <michal.winiarski@intel.com> > --- > Documentation/gpu/drm-internals.rst | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/Documentation/gpu/drm-internals.rst b/Documentation/gpu/drm-internals.rst > index 5fd20a306718..c264a9587d21 100644 > --- a/Documentation/gpu/drm-internals.rst > +++ b/Documentation/gpu/drm-internals.rst > @@ -228,16 +228,11 @@ follows: > > .. code-block:: bash > > - $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests \ > - --kconfig_add CONFIG_VIRTIO_UML=y \ > - --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y > + $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests > > .. note:: > The configuration included in ``.kunitconfig`` should be as generic as > possible. > - ``CONFIG_VIRTIO_UML`` and ``CONFIG_UML_PCI_OVER_VIRTIO`` are not > - included in it because they are only required for User Mode Linux. > - > > Legacy Support Code > =================== > -- > 2.37.3 > Thanks for the patch. This was in my ToDo list and I was waiting until 6fc3a8636a7b was merged in the DRM tree, but since you already fixed it I can mark it as done. Thanks!
diff --git a/Documentation/gpu/drm-internals.rst b/Documentation/gpu/drm-internals.rst index 5fd20a306718..c264a9587d21 100644 --- a/Documentation/gpu/drm-internals.rst +++ b/Documentation/gpu/drm-internals.rst @@ -228,16 +228,11 @@ follows: .. code-block:: bash - $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests \ - --kconfig_add CONFIG_VIRTIO_UML=y \ - --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y + $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests .. note:: The configuration included in ``.kunitconfig`` should be as generic as possible. - ``CONFIG_VIRTIO_UML`` and ``CONFIG_UML_PCI_OVER_VIRTIO`` are not - included in it because they are only required for User Mode Linux. - Legacy Support Code ===================
When built for UML, KUnit provides virtio/PCI, which means that the DMA/IOMEM UML emulation needed by DRM is already present and does not need to be manually added with --kconfig_add. References: commit 6fc3a8636a7b ("kunit: tool: Enable virtio/PCI by default on UML") Signed-off-by: Michał Winiarski <michal.winiarski@intel.com> --- Documentation/gpu/drm-internals.rst | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)