| Message ID | 20220920170937.14486-2-macroalpha82@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panel: Add Samsung AMS495QA01 Panel | expand |
Hello, Thanks for the patch, It's so nice seeing more pieces of RG503 being upstreamed. wt., 20 wrz 2022 o 19:10 Chris Morgan <macroalpha82@gmail.com> napisał(a): > > From: Chris Morgan <macromorgan@hotmail.com> > > Add documentation for the Samsung AMS495QA01 panel. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > .../display/panel/samsung,ams495qa01.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,ams495qa01.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,ams495qa01.yaml b/Documentation/devicetree/bindings/display/panel/samsung,ams495qa01.yaml > new file mode 100644 > index 000000000000..08358cdad19c > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/samsung,ams495qa01.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/samsung,ams495qa01.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung AMS495QA01 4.95in 960x544 DSI/SPI panel > + > +maintainers: > + - Chris Morgan <macromorgan@hotmail.com> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: samsung,ams495qa01 > + reg: true > + reset-gpios: true > + elvdd-supply: > + description: regulator that supplies voltage to the panel display Datasheet says about that pin: "Power pin for module analog", maybe in description that could be accounted for? > + enable-gpios: true > + port: true > + vdd-supply: > + description: regulator that supplies voltage to panel logic Maybe change that to "panel's logic"? > + > +required: > + - compatible > + - reg > + - vdd-supply > + > +additionalProperties: false > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + panel@0 { > + compatible = "samsung,ams495qa01"; > + reg = <0>; > + vdd-supply = <&vcc3v3_lcd0_n>; > + }; Where's the node of DSI controller the panel's attached to? > + }; > + > +... > -- > 2.25.1 > Best Regards, Maya Matuszczyk
On 20/09/2022 19:09, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add documentation for the Samsung AMS495QA01 panel. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > .../display/panel/samsung,ams495qa01.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,ams495qa01.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,ams495qa01.yaml b/Documentation/devicetree/bindings/display/panel/samsung,ams495qa01.yaml > new file mode 100644 > index 000000000000..08358cdad19c > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/samsung,ams495qa01.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/samsung,ams495qa01.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung AMS495QA01 4.95in 960x544 DSI/SPI panel > + > +maintainers: > + - Chris Morgan <macromorgan@hotmail.com> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: samsung,ams495qa01 Blank line. > + reg: true > + reset-gpios: true > + elvdd-supply: > + description: regulator that supplies voltage to the panel display > + enable-gpios: true > + port: true > + vdd-supply: > + description: regulator that supplies voltage to panel logic Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,ams495qa01.yaml b/Documentation/devicetree/bindings/display/panel/samsung,ams495qa01.yaml new file mode 100644 index 000000000000..08358cdad19c --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/samsung,ams495qa01.yaml @@ -0,0 +1,46 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/samsung,ams495qa01.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung AMS495QA01 4.95in 960x544 DSI/SPI panel + +maintainers: + - Chris Morgan <macromorgan@hotmail.com> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: samsung,ams495qa01 + reg: true + reset-gpios: true + elvdd-supply: + description: regulator that supplies voltage to the panel display + enable-gpios: true + port: true + vdd-supply: + description: regulator that supplies voltage to panel logic + +required: + - compatible + - reg + - vdd-supply + +additionalProperties: false + +examples: + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "samsung,ams495qa01"; + reg = <0>; + vdd-supply = <&vcc3v3_lcd0_n>; + }; + }; + +...