From patchwork Sat Sep 24 01:56:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuan Can X-Patchwork-Id: 12987328 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF3E8C04A95 for ; Sat, 24 Sep 2022 02:15:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 870CC10EB72; Sat, 24 Sep 2022 02:15:34 +0000 (UTC) X-Greylist: delayed 997 seconds by postgrey-1.36 at gabe; Sat, 24 Sep 2022 02:15:29 UTC Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1BD0D10EB72 for ; Sat, 24 Sep 2022 02:15:28 +0000 (UTC) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4MZBsV6WWkz1P6wh; Sat, 24 Sep 2022 09:54:38 +0800 (CST) Received: from huawei.com (10.175.112.208) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 24 Sep 2022 09:58:48 +0800 From: Yuan Can To: , , , , , , , Subject: [PATCH 03/10] drm/panel: elida-kd35t133: Use dev_err_probe() to simplify code Date: Sat, 24 Sep 2022 01:56:09 +0000 Message-ID: <20220924015616.34293-4-yuancan@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220924015616.34293-1-yuancan@huawei.com> References: <20220924015616.34293-1-yuancan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.112.208] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can --- drivers/gpu/drm/panel/panel-elida-kd35t133.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-elida-kd35t133.c b/drivers/gpu/drm/panel/panel-elida-kd35t133.c index eee714cf3f49..ffed705201af 100644 --- a/drivers/gpu/drm/panel/panel-elida-kd35t133.c +++ b/drivers/gpu/drm/panel/panel-elida-kd35t133.c @@ -257,20 +257,14 @@ static int kd35t133_probe(struct mipi_dsi_device *dsi) } ctx->vdd = devm_regulator_get(dev, "vdd"); - if (IS_ERR(ctx->vdd)) { - ret = PTR_ERR(ctx->vdd); - if (ret != -EPROBE_DEFER) - dev_err(dev, "Failed to request vdd regulator: %d\n", ret); - return ret; - } + if (IS_ERR(ctx->vdd)) + return dev_err_probe(dev, PTR_ERR(ctx->vdd), + "Failed to request vdd regulator\n"); ctx->iovcc = devm_regulator_get(dev, "iovcc"); - if (IS_ERR(ctx->iovcc)) { - ret = PTR_ERR(ctx->iovcc); - if (ret != -EPROBE_DEFER) - dev_err(dev, "Failed to request iovcc regulator: %d\n", ret); - return ret; - } + if (IS_ERR(ctx->iovcc)) + return dev_err_probe(dev, PTR_ERR(ctx->iovcc), + "Failed to request iovcc regulator\n"); ret = of_drm_get_panel_orientation(dev->of_node, &ctx->orientation); if (ret < 0) {