From patchwork Thu Dec 1 08:42:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 13061067 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F07AC43217 for ; Thu, 1 Dec 2022 08:44:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 238E210E572; Thu, 1 Dec 2022 08:44:26 +0000 (UTC) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D05510E56E for ; Thu, 1 Dec 2022 08:44:18 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 97CC15C01BB; Thu, 1 Dec 2022 03:44:17 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 01 Dec 2022 03:44:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1669884257; x= 1669970657; bh=xhtPz8Dqfioscgg3yoemS47J761NmMtmupbcefOZt74=; b=L EPujtsgIwX9f0NvrpTUvntk97RsOQ+/vo7iQc8rjmEyChhHV3VEga350Tvp8cO0y N9MKH5vP5y4vF+EB1U5bc93YwDhDEW6zAgF+ViC8O2FfASifS6aIvBU2BLC0AQQ2 lp/o3AdYfCuJCaOwmZdtfBpuLEJCCsZAEbxHqdHBpL8FXed6VaXrBRC4ht6ATaN1 hRMXdZDhql0KdRVxMdUiLfk9PpJdU/wwRbSgGvnd0fh3AlY6rM4TCspa2CJ+qM33 AASkTBOg63ubv48QWqP4RMG9ky5YgkMyfQQxCKRVYLnoOxE58b2qRKyatXZPjoO4 RAxPQ0q6og2WrDpjITlqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1669884257; x= 1669970657; bh=xhtPz8Dqfioscgg3yoemS47J761NmMtmupbcefOZt74=; b=Y uxkCK706usNCWT/0noaHtovqnraHJGKlOkm+znWiY3dqjjmINVbDI6UNlTG09u1m 3W08iWKxkRSKQ7/pl62UYTZd0G3+YrJ5yltG9CrjjrSGH4epIZwkA+AxieZ4AbIf FVD/1d1yj0r6ubChen63Za4XmSJKdB+UYdEG7edGf2aUgCmsWKpk/6c86QBVQ3Fz yszH0URpNUT7LTJSe1v1oCa4x493WHNvPdpCQU0BykFQeSGxTKPAAbI9hBUaVD1Z 5fZVQWPTG5rrzZ84bGZ4kJux30sQH/xJeJBgRKvJ3X4rmSxWZQ7+OzhOggv/kJ+d RxK+um0h0cNDfH4ms3Hcg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrtdeggdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 1 Dec 2022 03:44:16 -0500 (EST) From: Maxime Ripard Date: Thu, 01 Dec 2022 09:42:52 +0100 Subject: [PATCH v3 7/7] drm/vc4: dpi: Fix format mapping for RGB565 MIME-Version: 1.0 Message-Id: <20221013-rpi-dpi-improvements-v3-7-eb76e26a772d@cerno.tech> References: <20221013-rpi-dpi-improvements-v3-0-eb76e26a772d@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v3-0-eb76e26a772d@cerno.tech> To: Maxime Ripard , Daniel Vetter , Rob Herring , David Airlie , Emma Anholt , Eric Anholt X-Mailer: b4 0.10.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1022; i=maxime@cerno.tech; h=from:subject:message-id; bh=43Ff0zFIOvU8ONzBI2sMboXcyvjpYfdtbjUUqEZ+IMo=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMkdmeyBO2J0pyzr3P+f64RJ9zzB10/KgzcvuVzG6r3T/gL/ zwkMHaUsDGJcDLJiiiwxwuZL4k7Net3JxjcPZg4rE8gQBi5OAZjInluMDHfyr4ryz/qj8kzhQ0AvK9 8UFu+G2MN8ET+NuM8yrJO+6cjIMHfT0mm+4eyCeqr/e1Q6wlpapRinGJ+cME19xmmDXVZCjAA= X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Pinchart , Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Joerg Quinten , Laurent Pinchart , Chris Morgan , Maxime Ripard Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Dave Stevenson The mapping is incorrect for RGB565_1X16 as it should be DPI_FORMAT_18BIT_666_RGB_1 instead of DPI_FORMAT_18BIT_666_RGB_3. Fixes: 08302c35b59d ("drm/vc4: Add DPI driver") Signed-off-by: Dave Stevenson Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_dpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index fdae02760b6d..a7bebfa5d5b0 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -185,7 +185,7 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder) DPI_FORMAT); break; case MEDIA_BUS_FMT_RGB565_1X16: - dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_3, + dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_1, DPI_FORMAT); break; case MEDIA_BUS_FMT_RGB565_1X24_CPADHI: