| Message ID | 20221019062347.3756071-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] drm/amd/display: make dcn32_mpc_funcs static | expand |
On 2022-10-19 02:23, ruanjinjie wrote: > The symbol is not used outside of the file, so mark it static. > > Fixes the following warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mpc.c:985:24: warning: > symbol 'dcn32_mpc_funcs' was not declared. Should it be static? > > Signed-off-by: ruanjinjie <ruanjinjie@huawei.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> Harry > --- > drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c > index 4edd0655965b..206a5ddbaf6d 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c > @@ -982,7 +982,7 @@ static bool mpc32_program_3dlut( > return true; > } > > -const struct mpc_funcs dcn32_mpc_funcs = { > +static const struct mpc_funcs dcn32_mpc_funcs = { > .read_mpcc_state = mpc1_read_mpcc_state, > .insert_plane = mpc1_insert_plane, > .remove_mpcc = mpc1_remove_mpcc,
Applied. Thanks! Alex On Wed, Oct 19, 2022 at 9:28 AM Harry Wentland <harry.wentland@amd.com> wrote: > > On 2022-10-19 02:23, ruanjinjie wrote: > > The symbol is not used outside of the file, so mark it static. > > > > Fixes the following warning: > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mpc.c:985:24: warning: > > symbol 'dcn32_mpc_funcs' was not declared. Should it be static? > > > > Signed-off-by: ruanjinjie <ruanjinjie@huawei.com> > > Reviewed-by: Harry Wentland <harry.wentland@amd.com> > > Harry > > > --- > > drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c > > index 4edd0655965b..206a5ddbaf6d 100644 > > --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c > > +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c > > @@ -982,7 +982,7 @@ static bool mpc32_program_3dlut( > > return true; > > } > > > > -const struct mpc_funcs dcn32_mpc_funcs = { > > +static const struct mpc_funcs dcn32_mpc_funcs = { > > .read_mpcc_state = mpc1_read_mpcc_state, > > .insert_plane = mpc1_insert_plane, > > .remove_mpcc = mpc1_remove_mpcc, >
diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c index 4edd0655965b..206a5ddbaf6d 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c @@ -982,7 +982,7 @@ static bool mpc32_program_3dlut( return true; } -const struct mpc_funcs dcn32_mpc_funcs = { +static const struct mpc_funcs dcn32_mpc_funcs = { .read_mpcc_state = mpc1_read_mpcc_state, .insert_plane = mpc1_insert_plane, .remove_mpcc = mpc1_remove_mpcc,
The symbol is not used outside of the file, so mark it static. Fixes the following warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mpc.c:985:24: warning: symbol 'dcn32_mpc_funcs' was not declared. Should it be static? Signed-off-by: ruanjinjie <ruanjinjie@huawei.com> --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)