diff mbox series

driver: gpu: add failure check for ftell

Message ID 20221107073323.1283046-1-speakshen@163.com (mailing list archive)
State New, archived
Headers show
Series driver: gpu: add failure check for ftell | expand

Commit Message

SPeak Shen Nov. 7, 2022, 7:33 a.m. UTC 
From: shenyanfeng <shenyanfeng@xiaomi.com>

add return-value check of ftell to improve robustness(and avoid abnormal behavior)

Signed-off-by: SPeak <speakshen@163.com>
Signed-off-by: shenyanfeng <shenyanfeng@xiaomi.com>
---


Receive "Undelivered Mail Returned to Sender", so send again


 drivers/gpu/drm/radeon/mkregtable.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/radeon/mkregtable.c b/drivers/gpu/drm/radeon/mkregtable.c
index 52a7246fe..c31c58e5f 100644
--- a/drivers/gpu/drm/radeon/mkregtable.c
+++ b/drivers/gpu/drm/radeon/mkregtable.c
@@ -193,6 +193,7 @@  static int parser_auth(struct table *t, const char *filename)
 	regmatch_t match[4];
 	char buf[1024];
 	size_t end;
+	long pos;
 	int len;
 	int done = 0;
 	int r;
@@ -228,12 +229,12 @@  static int parser_auth(struct table *t, const char *filename)
 	last_reg = strtol(last_reg_s, NULL, 16);
 
 	do {
-		if (fgets(buf, 1024, file) == NULL) {
+		if ((fgets(buf, 1024, file) == NULL) || (pos = ftell(file)) < 0) {
 			fclose(file);
 			return -1;
 		}
 		len = strlen(buf);
-		if (ftell(file) == end)
+		if (pos == end)
 			done = 1;
 		if (len) {
 			r = regexec(&mask_rex, buf, 4, match, 0);