| Message ID | 20221111091130.57178-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/5] drm/nouveau/nvfw/acr: make wpr_generic_header_dump() static | expand |
For the whole series: Reviewed-by: Lyude Paul <lyude@redhat.com> Will push to drm-misc-next in a bit On Fri, 2022-11-11 at 17:11 +0800, Jiapeng Chong wrote: > This symbol is not used outside of acr.c, so marks it static. > > drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype for ‘wpr_generic_header_dump’. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3023 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c > index 83a9c48bc58c..7ac90c495737 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c > +++ b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c > @@ -45,7 +45,7 @@ wpr_header_v1_dump(struct nvkm_subdev *subdev, const struct wpr_header_v1 *hdr) > nvkm_debug(subdev, "\tstatus : %d\n", hdr->status); > } > > -void > +static void > wpr_generic_header_dump(struct nvkm_subdev *subdev, const struct wpr_generic_header *hdr) > { > nvkm_debug(subdev, "wprGenericHeader\n");
Actually hm, I think ben will need to consider pulling these into his branch since these don't seem to apply to drm-misc-next - so presumably they're related to some of the work that's been getting pushed recently for GSP prep On Fri, 2022-11-11 at 17:11 +0800, Jiapeng Chong wrote: > This symbol is not used outside of acr.c, so marks it static. > > drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype for ‘wpr_generic_header_dump’. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3023 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c > index 83a9c48bc58c..7ac90c495737 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c > +++ b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c > @@ -45,7 +45,7 @@ wpr_header_v1_dump(struct nvkm_subdev *subdev, const struct wpr_header_v1 *hdr) > nvkm_debug(subdev, "\tstatus : %d\n", hdr->status); > } > > -void > +static void > wpr_generic_header_dump(struct nvkm_subdev *subdev, const struct wpr_generic_header *hdr) > { > nvkm_debug(subdev, "wprGenericHeader\n");
diff --git a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c index 83a9c48bc58c..7ac90c495737 100644 --- a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c +++ b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c @@ -45,7 +45,7 @@ wpr_header_v1_dump(struct nvkm_subdev *subdev, const struct wpr_header_v1 *hdr) nvkm_debug(subdev, "\tstatus : %d\n", hdr->status); } -void +static void wpr_generic_header_dump(struct nvkm_subdev *subdev, const struct wpr_generic_header *hdr) { nvkm_debug(subdev, "wprGenericHeader\n");
This symbol is not used outside of acr.c, so marks it static. drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype for ‘wpr_generic_header_dump’. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3023 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)