| Message ID | 20221116091712.1309651-2-maxime@cerno.tech (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] drm/tests: Include helpers header | expand |
Hi Maxime, On 11/16/22 06:17, Maxime Ripard wrote: > The MODULE_LICENSE macro is missing from the kunit helpers file, thus > leading to a build error. > > Let's introduce it along with MODULE_AUTHOR. > > Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers") > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Maxime Ripard <maxime@cerno.tech> It would be nice to add the SPDX-License-Identifier tag in the source file as well. Besides that, Reviewed-by: Maíra Canal <mairacanal@riseup.net> Best Regards, - Maíra Canal > --- > drivers/gpu/drm/tests/drm_kunit_helpers.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c > index dbd8ec24d4be..eea450de7de8 100644 > --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c > +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c > @@ -64,3 +64,6 @@ struct drm_device *drm_kunit_device_init(struct kunit *test, u32 features, char > > return drm; > } > + > +MODULE_AUTHOR("Maxime Ripard <maxime@cerno.tech>"); > +MODULE_LICENSE("GPL");
On Wed, 16 Nov 2022, Maíra Canal <mairacanal@riseup.net> wrote: > Hi Maxime, > > On 11/16/22 06:17, Maxime Ripard wrote: >> The MODULE_LICENSE macro is missing from the kunit helpers file, thus >> leading to a build error. >> >> Let's introduce it along with MODULE_AUTHOR. >> >> Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers") >> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> >> Signed-off-by: Maxime Ripard <maxime@cerno.tech> > > It would be nice to add the SPDX-License-Identifier tag in the source > file as well. Besides that, It's not just nice, it's basically mandatory to add license boilerplate. Checkpatch would've warned about this. And actually about a lot of stuff in the series. (And our CI checkpatch did too, although we don't send the replies to the world, just intel-gfx [1].) BR, Jani. [1] https://lore.kernel.org/r/166846421165.32750.1193593124785451784@emeril.freedesktop.org
On Wed, Nov 16, 2022 at 01:32:51PM +0200, Jani Nikula wrote: > On Wed, 16 Nov 2022, Maíra Canal <mairacanal@riseup.net> wrote: > > Hi Maxime, > > > > On 11/16/22 06:17, Maxime Ripard wrote: > >> The MODULE_LICENSE macro is missing from the kunit helpers file, thus > >> leading to a build error. > >> > >> Let's introduce it along with MODULE_AUTHOR. > >> > >> Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers") > >> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > >> Signed-off-by: Maxime Ripard <maxime@cerno.tech> > > > > It would be nice to add the SPDX-License-Identifier tag in the source > > file as well. Besides that, > > It's not just nice, it's basically mandatory to add license boilerplate. > > Checkpatch would've warned about this. And actually about a lot of stuff > in the series. Right, sorry about that. I'll send additional patches to address the issues already in. > (And our CI checkpatch did too, although we don't send the replies to > the world, just intel-gfx [1].) I'm not sure how helpful it is though if the author is not a recipient of the report Maxime
On Wed, 16 Nov 2022 10:17:11 +0100, Maxime Ripard wrote: > The MODULE_LICENSE macro is missing from the kunit helpers file, thus > leading to a build error. > > Let's introduce it along with MODULE_AUTHOR. > > Applied to local tree (tmp). Thanks! Maxime
On Wed, 16 Nov 2022, Maxime Ripard <maxime@cerno.tech> wrote: > On Wed, Nov 16, 2022 at 01:32:51PM +0200, Jani Nikula wrote: >> On Wed, 16 Nov 2022, Maíra Canal <mairacanal@riseup.net> wrote: >> > Hi Maxime, >> > >> > On 11/16/22 06:17, Maxime Ripard wrote: >> >> The MODULE_LICENSE macro is missing from the kunit helpers file, thus >> >> leading to a build error. >> >> >> >> Let's introduce it along with MODULE_AUTHOR. >> >> >> >> Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers") >> >> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> >> >> Signed-off-by: Maxime Ripard <maxime@cerno.tech> >> > >> > It would be nice to add the SPDX-License-Identifier tag in the source >> > file as well. Besides that, >> >> It's not just nice, it's basically mandatory to add license boilerplate. >> >> Checkpatch would've warned about this. And actually about a lot of stuff >> in the series. > > Right, sorry about that. I'll send additional patches to address the > issues already in. > >> (And our CI checkpatch did too, although we don't send the replies to >> the world, just intel-gfx [1].) > > I'm not sure how helpful it is though if the author is not a recipient > of the report It actually should be, but I have absolutely no idea why in this case it decided to do To: "Mateusz Kwiatkowski" <kfyatek@gmail.com> instead of you. Baffled. BR, Jani.
diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c index dbd8ec24d4be..eea450de7de8 100644 --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c @@ -64,3 +64,6 @@ struct drm_device *drm_kunit_device_init(struct kunit *test, u32 features, char return drm; } + +MODULE_AUTHOR("Maxime Ripard <maxime@cerno.tech>"); +MODULE_LICENSE("GPL");
The MODULE_LICENSE macro is missing from the kunit helpers file, thus leading to a build error. Let's introduce it along with MODULE_AUTHOR. Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/gpu/drm/tests/drm_kunit_helpers.c | 3 +++ 1 file changed, 3 insertions(+)