| Message ID | 20221117133655.4.If6153da69ec4bc9e83d5f095ef6e6b07283940a5@changeid (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/5] drm/panel-edp: Use ktime_get_boottime for delays | expand |
Hi, On Thu, Nov 17, 2022 at 12:39 PM Drew Davenport <ddavenport@chromium.org> wrote: > > Same change as done for panel-samsung-atna33xc20. Extend the autosuspend > delay to avoid oscillating between power status during boot. > > Signed-off-by: Drew Davenport <ddavenport@chromium.org> > --- > > drivers/gpu/drm/bridge/parade-ps8640.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This seems fine to me. Not 100% sure what changed in the probing / booting to make it need 2 seconds now, but this really shouldn't cause any issues and it's nice to avoid those slow power cycles. Reviewed-by: Douglas Anderson <dianders@chromium.org>
Hi, On Thu, Nov 17, 2022 at 1:14 PM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Thu, Nov 17, 2022 at 12:39 PM Drew Davenport <ddavenport@chromium.org> wrote: > > > > Same change as done for panel-samsung-atna33xc20. Extend the autosuspend > > delay to avoid oscillating between power status during boot. > > > > Signed-off-by: Drew Davenport <ddavenport@chromium.org> > > --- > > > > drivers/gpu/drm/bridge/parade-ps8640.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > This seems fine to me. Not 100% sure what changed in the probing / > booting to make it need 2 seconds now, but this really shouldn't cause > any issues and it's nice to avoid those slow power cycles. > > Reviewed-by: Douglas Anderson <dianders@chromium.org> Pushed to drm-misc-next: b1d2751c2f23 drm/bridge/parade-ps8640: Extend autosuspend
diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c index 6a614e54b383c..f74090a9cc9e8 100644 --- a/drivers/gpu/drm/bridge/parade-ps8640.c +++ b/drivers/gpu/drm/bridge/parade-ps8640.c @@ -734,13 +734,13 @@ static int ps8640_probe(struct i2c_client *client) pm_runtime_enable(dev); /* * Powering on ps8640 takes ~300ms. To avoid wasting time on power - * cycling ps8640 too often, set autosuspend_delay to 1000ms to ensure + * cycling ps8640 too often, set autosuspend_delay to 2000ms to ensure * the bridge wouldn't suspend in between each _aux_transfer_msg() call * during EDID read (~20ms in my experiment) and in between the last * _aux_transfer_msg() call during EDID read and the _pre_enable() call * (~100ms in my experiment). */ - pm_runtime_set_autosuspend_delay(dev, 1000); + pm_runtime_set_autosuspend_delay(dev, 2000); pm_runtime_use_autosuspend(dev); pm_suspend_ignore_children(dev, true); ret = devm_add_action_or_reset(dev, ps8640_runtime_disable, dev);
Same change as done for panel-samsung-atna33xc20. Extend the autosuspend delay to avoid oscillating between power status during boot. Signed-off-by: Drew Davenport <ddavenport@chromium.org> --- drivers/gpu/drm/bridge/parade-ps8640.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)