From patchwork Wed Nov 23 15:25:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 13053854 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 384E9C4332F for ; Wed, 23 Nov 2022 15:29:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E827C10E58C; Wed, 23 Nov 2022 15:29:47 +0000 (UTC) Received: from wnew2-smtp.messagingengine.com (wnew2-smtp.messagingengine.com [64.147.123.27]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C44510E58D for ; Wed, 23 Nov 2022 15:29:44 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id 087A22B069B4; Wed, 23 Nov 2022 10:29:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 23 Nov 2022 10:29:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1669217380; x= 1669224580; bh=gc0BXwb5bluI/zyuR6CU1vX2ec6LXqibyP1pyi/zGq0=; b=D XxMrOoV7TODmraRB9LmHr8ntAWzbOyjbqFre3MxxNmj+YsWXCEwEylVJZAPI+V+5 cTYm+xsit7JMCPKfojqA9B4nmYHbHE9DdetLAh1T4BXVHyMpquRBpP+SWI/IuIyL 5bBedoaPcjhtC8a+GTFeRa0Q1h3K10+HUUhActkIzt7BM7ZAq5MnH6YnwQfSN0hh qzHr2TKfpT29PpMO2S+1BTEXu4YMQJDySkLHSkwflxljanF5B0aPR58fQjvcOIlE DImMj6Wuxd7ADA2ET/fp5TUl/H1n2COGe3D2cQN1PykaVodo/em5Z2gOPsE+lEJv me3blGxr0VVipVfWpEUDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1669217380; x= 1669224580; bh=gc0BXwb5bluI/zyuR6CU1vX2ec6LXqibyP1pyi/zGq0=; b=N 3Y6HGfdSGJwAD7/lWkhOy80/tah0Ci3FVqFj1mBa4/rLCsnmPSns1OR2iOWNNCuw ebxPqQB/4usP7rZMjwziZO6n/Z9AAATnw8snaAgCC3T1iXmTJXUSb3WjqMatDSZi qVLsZ5MxJK6CXUsivOfvsQvydiWtKbIIm/eNOQ4P1d6tPbmqe63ast0lovofInJB XpfcoJ98Up4ZIkr8knRTZWwu4InRnNduS/fbFoP+8WZir1vnOX1dSpCsXTCOP1DR 3sWOhLJmVEwbTR9F+/Nb45X3kT12Y+6IHoifHWsGQrITt8Fmh45heljw+sfYdfdv 7jPgVw6CIdlZrm/0H6mIA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedriedugdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhfffugggtgffkfhgjvfevofesthekredtredtjeenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeduudduhfevjeetfeegvdffvdevvdejudegudekjeehtdelhfffveethfej ledtveenucevlhhushhtvghrufhiiigvpeehnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Nov 2022 10:29:39 -0500 (EST) From: Maxime Ripard Date: Wed, 23 Nov 2022 16:25:55 +0100 Subject: [PATCH 13/24] drm/vc4: kms: Constify the HVS old/new state helpers MIME-Version: 1.0 Message-Id: <20221123-rpi-kunit-tests-v1-13-051a0bb60a16@cerno.tech> References: <20221123-rpi-kunit-tests-v1-0-051a0bb60a16@cerno.tech> In-Reply-To: <20221123-rpi-kunit-tests-v1-0-051a0bb60a16@cerno.tech> To: Maxime Ripard , Maarten Lankhorst , Daniel Vetter , David Airlie , Thomas Zimmermann X-Mailer: b4 0.11.0-dev-d416f X-Developer-Signature: v=1; a=openpgp-sha256; l=1999; i=maxime@cerno.tech; h=from:subject:message-id; bh=3WI7m8nK+3ntxOkh1NnakmIwQNYzUzGhoRCBBnqFJAc=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMl11tXvyqc6Xtyz8qvXgUdLE9jkZx/Y7hGa8dl+ovJvgXXm a9i2dZSyMIhxMciKKbLECJsviTs163UnG988mDmsTCBDGLg4BWAiT68w/OFhOPRyyzLJ63+Nz/HYtc /pv3/VbcbrVfErVriq75vafEeQkaFXKCX/f6u/l3w5P3f8/iRtxgfPo9Pkbt37GnSxlk9wHTsA X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?unknown-8bit?q?David_Gow_=3Cdavidgow=40google=2Ecom=3E=2C_Brendan_Higg?= =?unknown-8bit?q?ins_=3Cbrendan=2Ehiggins=40linux=2Edev=3E=2C_Greg_Kroah-Ha?= =?unknown-8bit?q?rtman_=3Cgregkh=40linuxfoundation=2Eorg=3E=2C_Dave_Stevens?= =?unknown-8bit?q?on_=3Cdave=2Estevenson=40raspberrypi=2Ecom=3E=2C_Javier_Ma?= =?unknown-8bit?q?rtinez_Canillas_=3Cjavierm=40redhat=2Ecom=3E=2C_dri-devel?= =?unknown-8bit?q?=40lists=2Efreedesktop=2Eorg=2C_linux-kernel=40vger=2Ekern?= =?unknown-8bit?q?el=2Eorg=2C_linaro-mm-sig=40lists=2Elinaro=2Eorg=2C_Ma=C3?= =?unknown-8bit?q?=ADra_Canal_=3Cmairacanal=40riseup=2Enet=3E=2C_Maxime_Ripa?= =?unknown-8bit?q?rd_=3Cmaxime=40cerno=2Etech=3E=2C_linux-kselftest=40vger?= =?unknown-8bit?q?=2Ekernel=2Eorg=2C_kunit-dev=40googlegroups=2Ecom=2C_linux?= =?unknown-8bit?q?-media=40vger=2Ekernel=2Eorg?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The vc4_hvs_get_(old|new)_global_state functions don't modify the drm_atomic_state passed as an argument, so let's make it const. Signed-off-by: Maxime Ripard Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/vc4/vc4_drv.h | 4 ++-- drivers/gpu/drm/vc4/vc4_kms.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h index 6ff63036915c..855207c07e2e 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.h +++ b/drivers/gpu/drm/vc4/vc4_drv.h @@ -375,8 +375,8 @@ to_vc4_hvs_state(const struct drm_private_state *priv) } struct vc4_hvs_state *vc4_hvs_get_global_state(struct drm_atomic_state *state); -struct vc4_hvs_state *vc4_hvs_get_old_global_state(struct drm_atomic_state *state); -struct vc4_hvs_state *vc4_hvs_get_new_global_state(struct drm_atomic_state *state); +struct vc4_hvs_state *vc4_hvs_get_old_global_state(const struct drm_atomic_state *state); +struct vc4_hvs_state *vc4_hvs_get_new_global_state(const struct drm_atomic_state *state); struct vc4_plane { struct drm_plane base; diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c index cb2197622b2b..6c9949399310 100644 --- a/drivers/gpu/drm/vc4/vc4_kms.c +++ b/drivers/gpu/drm/vc4/vc4_kms.c @@ -173,7 +173,7 @@ vc4_ctm_commit(struct vc4_dev *vc4, struct drm_atomic_state *state) } struct vc4_hvs_state * -vc4_hvs_get_new_global_state(struct drm_atomic_state *state) +vc4_hvs_get_new_global_state(const struct drm_atomic_state *state) { struct vc4_dev *vc4 = to_vc4_dev(state->dev); struct drm_private_state *priv_state; @@ -186,7 +186,7 @@ vc4_hvs_get_new_global_state(struct drm_atomic_state *state) } struct vc4_hvs_state * -vc4_hvs_get_old_global_state(struct drm_atomic_state *state) +vc4_hvs_get_old_global_state(const struct drm_atomic_state *state) { struct vc4_dev *vc4 = to_vc4_dev(state->dev); struct drm_private_state *priv_state;