| Message ID | 20221214125821.12489-2-paul@crapouillou.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: bridge: it66121: IT6610 support and cleanups | expand |
On Wed, 14 Dec 2022 at 13:58, Paul Cercueil <paul@crapouillou.net> wrote: > > Add a new ite,it6610 compatible string to the IT66121 binding > documentation, since the two chips are very similar. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > .../devicetree/bindings/display/bridge/ite,it66121.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml > index 1b2185be92cd..72957be0ba3c 100644 > --- a/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml > @@ -17,7 +17,9 @@ description: | > > properties: > compatible: > - const: ite,it66121 > + enum: > + - ite,it66121 > + - ite,it6610 > > reg: > maxItems: 1 > -- > 2.35.1 > Reviewed-by: Robert Foss <robert.foss@linaro.org>
Le jeudi 15 décembre 2022 à 11:55 +0100, Robert Foss a écrit : > On Wed, 14 Dec 2022 at 13:58, Paul Cercueil <paul@crapouillou.net> > wrote: > > > > Add a new ite,it6610 compatible string to the IT66121 binding > > documentation, since the two chips are very similar. > > > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > > --- > > .../devicetree/bindings/display/bridge/ite,it66121.yaml | 4 > > +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml > > b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml > > index 1b2185be92cd..72957be0ba3c 100644 > > --- > > a/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml > > +++ > > b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml > > @@ -17,7 +17,9 @@ description: | > > > > properties: > > compatible: > > - const: ite,it66121 > > + enum: > > + - ite,it66121 > > + - ite,it6610 > > > > reg: > > maxItems: 1 > > -- > > 2.35.1 > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org> Series applied to drm-misc-next. Thanks for the reviews! Cheers, -Paul
On 16/12/2022 11:46, Paul Cercueil wrote: >>> properties: >>> compatible: >>> - const: ite,it66121 >>> + enum: >>> + - ite,it66121 >>> + - ite,it6610 These should be ordered alphabetically. What's with the tendency of adding always to the end? >>> >>> reg: >>> maxItems: 1 >>> -- >>> 2.35.1 >>> >> >> Reviewed-by: Robert Foss <robert.foss@linaro.org> > > Series applied to drm-misc-next. > I wished you give DT maintainers a bit more time than two days. Best regards, Krzysztof
Hi Krzysztof, Le vendredi 16 décembre 2022 à 12:21 +0100, Krzysztof Kozlowski a écrit : > On 16/12/2022 11:46, Paul Cercueil wrote: > > > > > properties: > > > > compatible: > > > > - const: ite,it66121 > > > > + enum: > > > > + - ite,it66121 > > > > + - ite,it6610 > > These should be ordered alphabetically. What's with the tendency of > adding always to the end? I'm too used to the "inverse christmas tree" sort :) I can send a quickfix patch if you really want alphabetical order. > > > > > > > > reg: > > > > maxItems: 1 > > > > -- > > > > 2.35.1 > > > > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org> > > > > Series applied to drm-misc-next. > > > I wished you give DT maintainers a bit more time than two days. Noted. Sorry about that. Cheers, -Paul
On 16/12/2022 13:21, Paul Cercueil wrote: > Hi Krzysztof, > > Le vendredi 16 décembre 2022 à 12:21 +0100, Krzysztof Kozlowski a > écrit : >> On 16/12/2022 11:46, Paul Cercueil wrote: >> >>>>> properties: >>>>> compatible: >>>>> - const: ite,it66121 >>>>> + enum: >>>>> + - ite,it66121 >>>>> + - ite,it6610 >> >> These should be ordered alphabetically. What's with the tendency of >> adding always to the end? > > I'm too used to the "inverse christmas tree" sort :) Since these are not variables and they will not get shorter, any christmas tree sorting here is the same conflict-prone as adding to the end. > > I can send a quickfix patch if you really want alphabetical order. No, no need. Best regards, Krzysztof
On Fri, Dec 16, 2022, 12:21 Krzysztof Kozlowski < krzysztof.kozlowski@linaro.org> wrote: > On 16/12/2022 11:46, Paul Cercueil wrote: > > >>> properties: > >>> compatible: > >>> - const: ite,it66121 > >>> + enum: > >>> + - ite,it66121 > >>> + - ite,it6610 > > These should be ordered alphabetically. What's with the tendency of > adding always to the end? > > >>> > >>> reg: > >>> maxItems: 1 > >>> -- > >>> 2.35.1 > >>> > >> > >> Reviewed-by: Robert Foss <robert.foss@linaro.org> > > > > Series applied to drm-misc-next. > > > I wished you give DT maintainers a bit more time than two days. > Noted. Will make it a week. > Best regards, > Krzysztof > >
On Fri, Dec 16, 2022 at 01:21:54PM +0100, Paul Cercueil wrote: > Hi Krzysztof, > > Le vendredi 16 décembre 2022 à 12:21 +0100, Krzysztof Kozlowski a > écrit : > > On 16/12/2022 11:46, Paul Cercueil wrote: > > > > > > > properties: > > > > > compatible: > > > > > - const: ite,it66121 > > > > > + enum: > > > > > + - ite,it66121 > > > > > + - ite,it6610 > > > > These should be ordered alphabetically. What's with the tendency of > > adding always to the end? > > I'm too used to the "inverse christmas tree" sort :) Come on, the DT standard is sideways christmas tree. ;) Rob
diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml index 1b2185be92cd..72957be0ba3c 100644 --- a/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml +++ b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml @@ -17,7 +17,9 @@ description: | properties: compatible: - const: ite,it66121 + enum: + - ite,it66121 + - ite,it6610 reg: maxItems: 1
Add a new ite,it6610 compatible string to the IT66121 binding documentation, since the two chips are very similar. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- .../devicetree/bindings/display/bridge/ite,it66121.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)