| Message ID | 20221230130025.240776-2-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | c7cb175bb1ef |
| Headers | show |
| Series | [1/2] drm/imx/dcss: Drop if blocks with always false condition | expand |
Hi, On Fri, Dec 30, 2022 at 02:00:25PM +0100, Uwe Kleine-König wrote: > The driver core takes care about removing driver data, so this can be > dropped from the driver. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com> Pushed to drm-misc-next. Thanks, laurentiu > --- > drivers/gpu/drm/imx/dcss/dcss-drv.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/imx/dcss/dcss-drv.c b/drivers/gpu/drm/imx/dcss/dcss-drv.c > index 5c88eecf2ce0..3d5402193a11 100644 > --- a/drivers/gpu/drm/imx/dcss/dcss-drv.c > +++ b/drivers/gpu/drm/imx/dcss/dcss-drv.c > @@ -74,8 +74,6 @@ static int dcss_drv_platform_probe(struct platform_device *pdev) > dcss_shutoff: > dcss_dev_destroy(mdrv->dcss); > > - dev_set_drvdata(dev, NULL); > - > err: > kfree(mdrv); > return err; > @@ -88,8 +86,6 @@ static int dcss_drv_platform_remove(struct platform_device *pdev) > dcss_kms_detach(mdrv->kms); > dcss_dev_destroy(mdrv->dcss); > > - dev_set_drvdata(&pdev->dev, NULL); > - > kfree(mdrv); > > return 0; > -- > 2.38.1 >
diff --git a/drivers/gpu/drm/imx/dcss/dcss-drv.c b/drivers/gpu/drm/imx/dcss/dcss-drv.c index 5c88eecf2ce0..3d5402193a11 100644 --- a/drivers/gpu/drm/imx/dcss/dcss-drv.c +++ b/drivers/gpu/drm/imx/dcss/dcss-drv.c @@ -74,8 +74,6 @@ static int dcss_drv_platform_probe(struct platform_device *pdev) dcss_shutoff: dcss_dev_destroy(mdrv->dcss); - dev_set_drvdata(dev, NULL); - err: kfree(mdrv); return err; @@ -88,8 +86,6 @@ static int dcss_drv_platform_remove(struct platform_device *pdev) dcss_kms_detach(mdrv->kms); dcss_dev_destroy(mdrv->dcss); - dev_set_drvdata(&pdev->dev, NULL); - kfree(mdrv); return 0;
The driver core takes care about removing driver data, so this can be dropped from the driver. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/gpu/drm/imx/dcss/dcss-drv.c | 4 ---- 1 file changed, 4 deletions(-)