From patchwork Mon Jan 16 10:28:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ma=C3=ADra_Canal?= X-Patchwork-Id: 13102875 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B58E2C46467 for ; Mon, 16 Jan 2023 10:30:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC8C510E2DD; Mon, 16 Jan 2023 10:30:18 +0000 (UTC) Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3110C10E2DD for ; Mon, 16 Jan 2023 10:30:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eUSEC2loK6JmCn4KYmfo6SNuJBTfIHXxRbVWdo/L9nQ=; b=CPXztSGvmnBvFbIbVD6y3D83U1 VZ5mUlvi27F2iqkI8GXzjsYOMabpglA0H8a1lowDTKzDdNDbI7jC0+cf2DCxHFYPmXTt7viR3jv8Z IUgwYLYGwxBHyfDdz0T2xHy2XB95WfHntRs9woR+bKIrBbaaxTYjwiA/SeqRFROsBgXZ4GM/sdQIN rUI/CDEFhlqTMmapEKKIpOtD7RRezPL/XDbTQXcsQKF6YqwvE+S2sJoPSYBHj8H5USvf993dnUbOH 8wOVGNrj36AmdLAJYg18y32EmbncFg7PLZ8aSqE/NOv9BgDLMq6JTzuN486nug/d6KUlH1ExB/e91 1ZtyNGHA==; Received: from [187.36.234.139] (helo=bowie..) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1pHMkX-009j44-TP; Mon, 16 Jan 2023 11:29:58 +0100 From: =?utf-8?q?Ma=C3=ADra_Canal?= To: Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Liviu Dudau , Brian Starkey , =?utf-8?q?Noralf_Tr=C3=B8nnes?= , Emma Anholt , Melissa Wen , Rodrigo Siqueira , Jani Nikula Subject: [PATCH 3/6] drm/debugfs: Create wrapper to add files to debugfs list Date: Mon, 16 Jan 2023 07:28:13 -0300 Message-Id: <20230116102815.95063-4-mcanal@igalia.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230116102815.95063-1-mcanal@igalia.com> References: <20230116102815.95063-1-mcanal@igalia.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Ma=C3=ADra_Canal?= , =?utf-8?q?Andr=C3=A9_A?= =?utf-8?q?lmeida?= , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Create a helper to encapsulate the code that adds a new debugfs file to a linked list related to a object. Moreover, the helper also provides more flexibily, as the parameter is a struct drm_debugfs_list. Signed-off-by: Maíra Canal --- drivers/gpu/drm/drm_debugfs.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c index 176b0f8614e5..aca460fa5d23 100644 --- a/drivers/gpu/drm/drm_debugfs.c +++ b/drivers/gpu/drm/drm_debugfs.c @@ -229,6 +229,13 @@ void drm_debugfs_list_destroy(struct drm_debugfs_list *debugfs_list) mutex_destroy(&debugfs_list->mutex); } +static void drm_debugfs_list_add(struct list_head *entry, struct drm_debugfs_list *debugfs_list) +{ + mutex_lock(&debugfs_list->mutex); + list_add(entry, &debugfs_list->list); + mutex_unlock(&debugfs_list->mutex); +} + int drm_debugfs_init(struct drm_minor *minor, int minor_id, struct dentry *root) { @@ -350,9 +357,7 @@ void drm_debugfs_add_file(struct drm_device *dev, const char *name, entry->file.data = data; entry->dev = dev; - mutex_lock(&dev->debugfs_list.mutex); - list_add(&entry->list, &dev->debugfs_list.list); - mutex_unlock(&dev->debugfs_list.mutex); + drm_debugfs_list_add(&entry->list, &dev->debugfs_list); } EXPORT_SYMBOL(drm_debugfs_add_file);