diff mbox series

[1/1] drm/bridge: sii902x: Use dev_err_probe

Message ID 20230117105903.2068235-1-alexander.stein@ew.tq-group.com (mailing list archive)
State New, archived
Headers show
Series [1/1] drm/bridge: sii902x: Use dev_err_probe | expand

Commit Message

Alexander Stein Jan. 17, 2023, 10:59 a.m. UTC
This helps figuring out why the device probe is deferred.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 drivers/gpu/drm/bridge/sii902x.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Andrzej Hajda Jan. 17, 2023, 11:27 a.m. UTC | #1
On 17.01.2023 11:59, Alexander Stein wrote:
> This helps figuring out why the device probe is deferred.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>   drivers/gpu/drm/bridge/sii902x.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
> index d212ff7f7a87..f4a8f227c41b 100644
> --- a/drivers/gpu/drm/bridge/sii902x.c
> +++ b/drivers/gpu/drm/bridge/sii902x.c
> @@ -1116,7 +1116,8 @@ static int sii902x_probe(struct i2c_client *client)
>   		sii902x->next_bridge = of_drm_find_bridge(remote);
>   		of_node_put(remote);
>   		if (!sii902x->next_bridge)
> -			return -EPROBE_DEFER;
> +			return dev_err_probe(dev, -EPROBE_DEFER,
> +					     "Failed to find remote bridge\n");

Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>

Regards
Andrzej

>   	}
>   
>   	mutex_init(&sii902x->mutex);
Neil Armstrong Jan. 19, 2023, 7:43 a.m. UTC | #2
Hi,

On Tue, 17 Jan 2023 11:59:03 +0100, Alexander Stein wrote:
> This helps figuring out why the device probe is deferred.
> 
> 

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/1] drm/bridge: sii902x: Use dev_err_probe
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=f8593120e321f8b21766db13c7333e9ae0740b65
diff mbox series

Patch

diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index d212ff7f7a87..f4a8f227c41b 100644
--- a/drivers/gpu/drm/bridge/sii902x.c
+++ b/drivers/gpu/drm/bridge/sii902x.c
@@ -1116,7 +1116,8 @@  static int sii902x_probe(struct i2c_client *client)
 		sii902x->next_bridge = of_drm_find_bridge(remote);
 		of_node_put(remote);
 		if (!sii902x->next_bridge)
-			return -EPROBE_DEFER;
+			return dev_err_probe(dev, -EPROBE_DEFER,
+					     "Failed to find remote bridge\n");
 	}
 
 	mutex_init(&sii902x->mutex);