| Message ID | 20230117110801.2069761-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm: fsl-dcu: Use dev_err_probe | expand |
Hi, any feedback on this series? Best regards, Alexander Am Dienstag, 17. Januar 2023, 12:08:00 CET schrieb Alexander Stein: > fsl_dcu_drm_modeset_init can return -EPROBE_DEFER, so use dev_err_probe > to remove an invalid error message and add it to deferral description. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c index > 8579c7629f5e..418887654bac 100644 > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > @@ -103,10 +103,8 @@ static int fsl_dcu_load(struct drm_device *dev, > unsigned long flags) int ret; > > ret = fsl_dcu_drm_modeset_init(fsl_dev); > - if (ret < 0) { > - dev_err(dev->dev, "failed to initialize mode setting\n"); > - return ret; > - } > + if (ret < 0) > + return dev_err_probe(dev->dev, ret, "failed to initialize mode > setting\n"); > > ret = drm_vblank_init(dev, dev->mode_config.num_crtc); > if (ret < 0) {
Hi, this series is uncommented for some time now. Any feedback? Thanks, Alexander Am Montag, 13. Februar 2023, 09:24:33 CET schrieb Alexander Stein: > Hi, > > any feedback on this series? > > Best regards, > Alexander > > Am Dienstag, 17. Januar 2023, 12:08:00 CET schrieb Alexander Stein: > > fsl_dcu_drm_modeset_init can return -EPROBE_DEFER, so use dev_err_probe > > to remove an invalid error message and add it to deferral description. > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > > > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > > b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c index > > 8579c7629f5e..418887654bac 100644 > > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > > @@ -103,10 +103,8 @@ static int fsl_dcu_load(struct drm_device *dev, > > unsigned long flags) int ret; > > > > ret = fsl_dcu_drm_modeset_init(fsl_dev); > > > > - if (ret < 0) { > > - dev_err(dev->dev, "failed to initialize mode setting\n"); > > - return ret; > > - } > > + if (ret < 0) > > + return dev_err_probe(dev->dev, ret, "failed to initialize > > mode > > > setting\n"); > > > > ret = drm_vblank_init(dev, dev->mode_config.num_crtc); > > if (ret < 0) {
Hello, another gentle ping. Alexander Am Dienstag, 17. Januar 2023, 12:08:00 CEST schrieb Alexander Stein: > fsl_dcu_drm_modeset_init can return -EPROBE_DEFER, so use dev_err_probe > to remove an invalid error message and add it to deferral description. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c index > 8579c7629f5e..418887654bac 100644 > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > @@ -103,10 +103,8 @@ static int fsl_dcu_load(struct drm_device *dev, > unsigned long flags) int ret; > > ret = fsl_dcu_drm_modeset_init(fsl_dev); > - if (ret < 0) { > - dev_err(dev->dev, "failed to initialize mode setting\n"); > - return ret; > - } > + if (ret < 0) > + return dev_err_probe(dev->dev, ret, "failed to initialize mode > setting\n"); > > ret = drm_vblank_init(dev, dev->mode_config.num_crtc); > if (ret < 0) {
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c index 8579c7629f5e..418887654bac 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c @@ -103,10 +103,8 @@ static int fsl_dcu_load(struct drm_device *dev, unsigned long flags) int ret; ret = fsl_dcu_drm_modeset_init(fsl_dev); - if (ret < 0) { - dev_err(dev->dev, "failed to initialize mode setting\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev->dev, ret, "failed to initialize mode setting\n"); ret = drm_vblank_init(dev, dev->mode_config.num_crtc); if (ret < 0) {
fsl_dcu_drm_modeset_init can return -EPROBE_DEFER, so use dev_err_probe to remove an invalid error message and add it to deferral description. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)