| Message ID | 20230118091833.87708-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/msm/dpu: Remove some unused variables | expand |
On 2023-01-18 17:18:33, Jiapeng Chong wrote: > Variables 'sc8280xp_regdma' and 'sm8350_regdma' are defined in the > dpu_hw_catalog.c file, but not used elsewhere, so remove these unused > variables. > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:2029:37: warning: unused > variable 'sc8280xp_regdma'. > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:2053:37: warning: unused > variable 'sm8350_regdma'. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3722 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Does this need a Fixes tag? > --- > Changes in v2: > -Adding the regdma entries to .dma_cfg of these chipsets. Don't forget to change the title of this patch; now you're not removing unused variables anymore. - Marijn > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > index 0f3da480b066..3318e1d18a0e 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > @@ -2677,6 +2677,8 @@ static const struct dpu_mdss_cfg sc8280xp_dpu_cfg = { > .intf = sc8280xp_intf, > .vbif_count = ARRAY_SIZE(sdm845_vbif), > .vbif = sdm845_vbif, > + .reg_dma_count = 1, > + .dma_cfg = &sc8280xp_regdma, > .perf = &sc8280xp_perf_data, > .mdss_irqs = IRQ_SC8280XP_MASK, > }; > @@ -2732,7 +2734,7 @@ static const struct dpu_mdss_cfg sm8350_dpu_cfg = { > .vbif_count = ARRAY_SIZE(sdm845_vbif), > .vbif = sdm845_vbif, > .reg_dma_count = 1, > - .dma_cfg = &sm8250_regdma, > + .dma_cfg = &sm8350_regdma, > .perf = &sm8350_perf_data, > .mdss_irqs = IRQ_SM8350_MASK, > }; > -- > 2.20.1.7.g153144c >
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c index 0f3da480b066..3318e1d18a0e 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c @@ -2677,6 +2677,8 @@ static const struct dpu_mdss_cfg sc8280xp_dpu_cfg = { .intf = sc8280xp_intf, .vbif_count = ARRAY_SIZE(sdm845_vbif), .vbif = sdm845_vbif, + .reg_dma_count = 1, + .dma_cfg = &sc8280xp_regdma, .perf = &sc8280xp_perf_data, .mdss_irqs = IRQ_SC8280XP_MASK, }; @@ -2732,7 +2734,7 @@ static const struct dpu_mdss_cfg sm8350_dpu_cfg = { .vbif_count = ARRAY_SIZE(sdm845_vbif), .vbif = sdm845_vbif, .reg_dma_count = 1, - .dma_cfg = &sm8250_regdma, + .dma_cfg = &sm8350_regdma, .perf = &sm8350_perf_data, .mdss_irqs = IRQ_SM8350_MASK, };
Variables 'sc8280xp_regdma' and 'sm8350_regdma' are defined in the dpu_hw_catalog.c file, but not used elsewhere, so remove these unused variables. drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:2029:37: warning: unused variable 'sc8280xp_regdma'. drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:2053:37: warning: unused variable 'sm8350_regdma'. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3722 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- Changes in v2: -Adding the regdma entries to .dma_cfg of these chipsets. drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)