| Message ID | 20230125-tfp410_i2c-v3-2-a85d5f0f50f1@criticallink.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: tfp410: Add i2c support | expand |
Hi, On 20/02/2023 23:10, Jonathan Cormier wrote: > From: Michael Williamson <michael.williamson@criticallink.com> > > The logic to configure polling (vs async/irq notification) of hot-plug > events was not correct. If the connected bridge requires polling, > then inform the upstream bridge we also require polling. > > Signed-off-by: Michael Williamson <michael.williamson@criticallink.com> > Signed-off-by: Jonathan Cormier <jcormier@criticallink.com> > --- > drivers/gpu/drm/bridge/ti-tfp410.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c > index bb3f8d0ff207..41007d05d584 100644 > --- a/drivers/gpu/drm/bridge/ti-tfp410.c > +++ b/drivers/gpu/drm/bridge/ti-tfp410.c > @@ -155,7 +155,7 @@ static int tfp410_attach(struct drm_bridge *bridge, > return -ENODEV; > } > > - if (dvi->next_bridge->ops & DRM_BRIDGE_OP_DETECT) > + if (dvi->next_bridge->ops & DRM_BRIDGE_OP_HPD) > dvi->connector.polled = DRM_CONNECTOR_POLL_HPD; > else > dvi->connector.polled = DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_DISCONNECT; > A Fixes tag is probably needed here ? With that: Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On Fri, Mar 31, 2023 at 5:00 AM Neil Armstrong <neil.armstrong@linaro.org> wrote: > > Hi, > > On 20/02/2023 23:10, Jonathan Cormier wrote: > > From: Michael Williamson <michael.williamson@criticallink.com> > > > > The logic to configure polling (vs async/irq notification) of hot-plug > > events was not correct. If the connected bridge requires polling, > > then inform the upstream bridge we also require polling. > > > > Signed-off-by: Michael Williamson <michael.williamson@criticallink.com> > > Signed-off-by: Jonathan Cormier <jcormier@criticallink.com> > > --- > > drivers/gpu/drm/bridge/ti-tfp410.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c > > index bb3f8d0ff207..41007d05d584 100644 > > --- a/drivers/gpu/drm/bridge/ti-tfp410.c > > +++ b/drivers/gpu/drm/bridge/ti-tfp410.c > > @@ -155,7 +155,7 @@ static int tfp410_attach(struct drm_bridge *bridge, > > return -ENODEV; > > } > > > > - if (dvi->next_bridge->ops & DRM_BRIDGE_OP_DETECT) > > + if (dvi->next_bridge->ops & DRM_BRIDGE_OP_HPD) > > dvi->connector.polled = DRM_CONNECTOR_POLL_HPD; > > else > > dvi->connector.polled = DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_DISCONNECT; > > > > A Fixes tag is probably needed here ? Thanks will do > > With that: > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c index bb3f8d0ff207..41007d05d584 100644 --- a/drivers/gpu/drm/bridge/ti-tfp410.c +++ b/drivers/gpu/drm/bridge/ti-tfp410.c @@ -155,7 +155,7 @@ static int tfp410_attach(struct drm_bridge *bridge, return -ENODEV; } - if (dvi->next_bridge->ops & DRM_BRIDGE_OP_DETECT) + if (dvi->next_bridge->ops & DRM_BRIDGE_OP_HPD) dvi->connector.polled = DRM_CONNECTOR_POLL_HPD; else dvi->connector.polled = DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_DISCONNECT;