| Message ID | 20230126-rpi-display-fw-clk-cleanup-v1-4-d646ff6fb842@cerno.tech (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/vc4: hdmi: Firmware clocks cleanup | expand |
On 1/26/23 18:05, Maxime Ripard wrote: > This reverts commit ae71ab585c819f83aec84f91eb01157a90552ef2. > > Commit ae71ab585c81 ("drm/vc4: hdmi: Enforce the minimum rate at > runtime_resume") was introduced to work around an issue partly due to > the clk-bcm2835 driver on the RaspberryPi0-3. > > Since we're not using that driver for our HDMI clocks, we can now revert > it. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > --- Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index e82fe17c9532..18d84aab54bb 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -3350,15 +3350,6 @@ static int vc4_hdmi_runtime_resume(struct device *dev) unsigned long rate; int ret; - /* - * The HSM clock is in the HDMI power domain, so we need to set - * its frequency while the power domain is active so that it - * keeps its rate. - */ - ret = clk_set_min_rate(vc4_hdmi->hsm_clock, HSM_MIN_CLOCK_FREQ); - if (ret) - return ret; - ret = clk_prepare_enable(vc4_hdmi->hsm_clock); if (ret) return ret;
This reverts commit ae71ab585c819f83aec84f91eb01157a90552ef2. Commit ae71ab585c81 ("drm/vc4: hdmi: Enforce the minimum rate at runtime_resume") was introduced to work around an issue partly due to the clk-bcm2835 driver on the RaspberryPi0-3. Since we're not using that driver for our HDMI clocks, we can now revert it. Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/gpu/drm/vc4/vc4_hdmi.c | 9 --------- 1 file changed, 9 deletions(-)