diff mbox series

[21/27] habanalabs: fix print in hl_irq_handler_eq()

Message ID	20230212204454.2938561-21-ogabbay@kernel.org (mailing list archive)
State	New, archived
Headers	show Return-Path: <dri-devel-bounces@lists.freedesktop.org> From: Oded Gabbay <ogabbay@kernel.org> To: dri-devel@lists.freedesktop.org Subject: [PATCH 21/27] habanalabs: fix print in hl_irq_handler_eq() Date: Sun, 12 Feb 2023 22:44:48 +0200 Message-Id: <20230212204454.2938561-21-ogabbay@kernel.org> In-Reply-To: <20230212204454.2938561-1-ogabbay@kernel.org> References: <20230212204454.2938561-1-ogabbay@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Cc: Tomer Tayar <ttayar@habana.ai> Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
Series	[01/27] habanalabs/gaudi2: increase user interrupt grace time \| expand [01/27] habanalabs/gaudi2: increase user interrupt grace time [02/27] habanalabs/gaudi: capture RAZWI info only if HW indication detected [03/27] habanalabs: split cdev creation to separate function [04/27] habanalabs: save class in hdev [05/27] habanalabs: refactor debugfs init [06/27] habanalabs: use memhash_node_export_put() in hl_release_dmabuf() [07/27] habanalabs/gaudi2: fix address decode RAZWI handling [08/27] habanalabs: add info when FD released while device still in use [09/27] habanalabs: enforce release order of compute device and dma-buf [10/27] habanalabs: add critical-event bit in notifier [11/27] habanalabs/gaudi2: expose engine core int reg address [12/27] habanalabs/gaudi2: unsecure CFG_TPC_ID register [13/27] habanalabs: minimize error prints when mem map fails [14/27] habanalabs: disable PCI when escalating compute to hard-reset [15/27] habanalabs: enable graceful reset mechanism for compute-reset [16/27] habanalabs/gaudi2: get reset type indication from irq_map [17/27] habanalabs/gaudi2: modify events reset policy [18/27] habanalabs: change user interrupt to threaded IRQ [19/27] habanalabs: capture interrupt timestamp in handler [20/27] habanalabs/gaudi2: add support for TPC assert [21/27] habanalabs: fix print in hl_irq_handler_eq() [22/27] habanalabs: remove hl_irq_handler_default() [23/27] habanalabs: tiny refactor of hl_device_reset for readability [24/27] habanalabs: rename security function parameters [25/27] habanalabs: in hl_device_reset remove 'hard_instead_of_soft' [26/27] habanalabs: in hl_device_reset small refactor for readabilty [27/27] habanalabs: don't trace cpu accessible dma alloc/free

Commit Message

Oded Gabbay Feb. 12, 2023, 8:44 p.m. UTC

From: Tomer Tayar <ttayar@habana.ai>

"eq_base[eq->ci].hdr.ctl" is used directly in a print without a
le32_to_cpu() conversion.

Signed-off-by: Tomer Tayar <ttayar@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
---
 drivers/accel/habanalabs/common/irq.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff mbox series

Patch

diff --git a/drivers/accel/habanalabs/common/irq.c b/drivers/accel/habanalabs/common/irq.c
index bd0e3413721b..4b062e8520f1 100644
--- a/drivers/accel/habanalabs/common/irq.c
+++ b/drivers/accel/habanalabs/common/irq.c
@@ -439,11 +439,10 @@  irqreturn_t hl_irq_handler_eq(int irq, void *arg)
 
 		cur_eqe_index = FIELD_GET(EQ_CTL_INDEX_MASK, cur_eqe);
 		if ((hdev->event_queue.check_eqe_index) &&
-				(((eq->prev_eqe_index + 1) & EQ_CTL_INDEX_MASK)
-							!= cur_eqe_index)) {
+				(((eq->prev_eqe_index + 1) & EQ_CTL_INDEX_MASK) != cur_eqe_index)) {
 			dev_dbg(hdev->dev,
-				"EQE 0x%x in queue is ready but index does not match %d!=%d",
-				eq_base[eq->ci].hdr.ctl,
+				"EQE %#x in queue is ready but index does not match %d!=%d",
+				cur_eqe,
 				((eq->prev_eqe_index + 1) & EQ_CTL_INDEX_MASK),
 				cur_eqe_index);
 			break;