From patchwork Mon Feb 20 09:19:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oded Gabbay X-Patchwork-Id: 13146187 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 953C2C636CC for ; Mon, 20 Feb 2023 09:19:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EF04110E62B; Mon, 20 Feb 2023 09:19:48 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA7B610E62B for ; Mon, 20 Feb 2023 09:19:46 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F2BEC60CA3; Mon, 20 Feb 2023 09:19:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82723C433EF; Mon, 20 Feb 2023 09:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676884785; bh=r0xDHBJceeddksXLSeSnGYYc+XcC31oPO32xYhBo70A=; h=From:To:Cc:Subject:Date:From; b=CHnWs/twTMVnJ3jXTzgvFwcmH1d7TsoMSNUdg+YDtkBFtYPP/gzuLITgZC9+75fHT HKmG3shs3GOCJMx1iOopyWjcBBKq/BNL1SdWSY8+rz9vowEZ338x2HoxPtNGeki5VL oy0gbC1fv18/WZMT5eIDIBviVLSIkRVCmmEirZqwN4fqWZemG7bKUxDmenCiDAUPpe xnH9KkV5pqiTAlXnXRYZUze8vc4oJQ1z5UUMXuQzWfofNETpcbpdE55pLqV6XL9NGn 9UcV5l2iknkLvM3SeCV7m3hnUpc5zMRc5+ilVixhe2IYOv2osDY15mGww/IkFdOVEr +o7wQUT/u2XlQ== From: Oded Gabbay To: dri-devel@lists.freedesktop.org Subject: [PATCH 1/4] habanalabs: organize hl_device structure comment Date: Mon, 20 Feb 2023 11:19:36 +0200 Message-Id: <20230220091939.3467487-1-ogabbay@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagiv Ozeri Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Sagiv Ozeri Make the comments align with the order of the fields in the structure Signed-off-by: Sagiv Ozeri Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay Reviewed-by: Stanislaw Gruszka for the whole series. --- drivers/accel/habanalabs/common/habanalabs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h index 7b6b4ff20a3b..de4ff525cbcb 100644 --- a/drivers/accel/habanalabs/common/habanalabs.h +++ b/drivers/accel/habanalabs/common/habanalabs.h @@ -3296,6 +3296,8 @@ struct hl_reset_info { * @supports_mmu_prefetch: true if prefetch is supported, otherwise false. * @reset_upon_device_release: reset the device when the user closes the file descriptor of the * device. + * @supports_ctx_switch: true if a ctx switch is required upon first submission. + * @support_preboot_binning: true if we support read binning info from preboot. * @nic_ports_mask: Controls which NIC ports are enabled. Used only for testing. * @fw_components: Controls which f/w components to load to the device. There are multiple f/w * stages and sometimes we want to stop at a certain stage. Used only for testing. @@ -3309,8 +3311,6 @@ struct hl_reset_info { * Used only for testing. * @heartbeat: Controls if we want to enable the heartbeat mechanism vs. the f/w, which verifies * that the f/w is always alive. Used only for testing. - * @supports_ctx_switch: true if a ctx switch is required upon first submission. - * @support_preboot_binning: true if we support read binning info from preboot. */ struct hl_device { struct pci_dev *pdev; @@ -3457,7 +3457,7 @@ struct hl_device { u8 supports_ctx_switch; u8 support_preboot_binning; - /* Parameters for bring-up */ + /* Parameters for bring-up to be upstreamed */ u64 nic_ports_mask; u64 fw_components; u8 mmu_enable;