| Message ID | 20230221184256.1436-3-quic_jesszhan@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Move TE setup to prepare_for_kickoff() | expand |
On 2023-02-21 10:42:54, Jessica Zhang wrote: > Add a NULL check before calling prepare_commit() in > msm_atomic_commit_tail() > > Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > drivers/gpu/drm/msm/msm_atomic.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/msm_atomic.c b/drivers/gpu/drm/msm/msm_atomic.c > index 1686fbb611fd..c8a0a5cc5ca5 100644 > --- a/drivers/gpu/drm/msm/msm_atomic.c > +++ b/drivers/gpu/drm/msm/msm_atomic.c > @@ -206,7 +206,8 @@ void msm_atomic_commit_tail(struct drm_atomic_state *state) > * Now that there is no in-progress flush, prepare the > * current update: > */ > - kms->funcs->prepare_commit(kms, state); > + if (kms->funcs->prepare_commit) > + kms->funcs->prepare_commit(kms, state); > > /* > * Push atomic updates down to hardware: > -- > 2.39.2 >
diff --git a/drivers/gpu/drm/msm/msm_atomic.c b/drivers/gpu/drm/msm/msm_atomic.c index 1686fbb611fd..c8a0a5cc5ca5 100644 --- a/drivers/gpu/drm/msm/msm_atomic.c +++ b/drivers/gpu/drm/msm/msm_atomic.c @@ -206,7 +206,8 @@ void msm_atomic_commit_tail(struct drm_atomic_state *state) * Now that there is no in-progress flush, prepare the * current update: */ - kms->funcs->prepare_commit(kms, state); + if (kms->funcs->prepare_commit) + kms->funcs->prepare_commit(kms, state); /* * Push atomic updates down to hardware: