diff mbox series

drm/vgem: Drop struct drm_vgem_gem_object

Message ID 20230222160617.171429-1-mcanal@igalia.com (mailing list archive)
State New, archived
Headers show
Series drm/vgem: Drop struct drm_vgem_gem_object | expand

Commit Message

Maíra Canal Feb. 22, 2023, 4:06 p.m. UTC
Commit 45d9c8dde4cd ("drm/vgem: use shmem helpers") introduced shmem
helpers to vgem and with that, removed all uses of the struct
drm_vgem_gem_object. So, as the struct is no longer used, delete it.

Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
 drivers/gpu/drm/vgem/vgem_drv.h | 11 -----------
 1 file changed, 11 deletions(-)

Comments

Melissa Wen March 15, 2023, 10:31 p.m. UTC | #1
On 02/22, Maíra Canal wrote:
> Commit 45d9c8dde4cd ("drm/vgem: use shmem helpers") introduced shmem
> helpers to vgem and with that, removed all uses of the struct
> drm_vgem_gem_object. So, as the struct is no longer used, delete it.
> 
Thanks,

Reviewed-by: Melissa Wen <mwen@igalia.com>

> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>  drivers/gpu/drm/vgem/vgem_drv.h | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.h b/drivers/gpu/drm/vgem/vgem_drv.h
> index 0ed300317f87..34cf63e6fb3d 100644
> --- a/drivers/gpu/drm/vgem/vgem_drv.h
> +++ b/drivers/gpu/drm/vgem/vgem_drv.h
> @@ -39,17 +39,6 @@ struct vgem_file {
>  	struct mutex fence_mutex;
>  };
>  
> -#define to_vgem_bo(x) container_of(x, struct drm_vgem_gem_object, base)
> -struct drm_vgem_gem_object {
> -	struct drm_gem_object base;
> -
> -	struct page **pages;
> -	unsigned int pages_pin_count;
> -	struct mutex pages_lock;
> -
> -	struct sg_table *table;
> -};
> -
>  int vgem_fence_open(struct vgem_file *file);
>  int vgem_fence_attach_ioctl(struct drm_device *dev,
>  			    void *data,
> -- 
> 2.39.2
>
Maíra Canal March 20, 2023, 7:07 p.m. UTC | #2
On 2/22/23 13:06, Maíra Canal wrote:
> Commit 45d9c8dde4cd ("drm/vgem: use shmem helpers") introduced shmem
> helpers to vgem and with that, removed all uses of the struct
> drm_vgem_gem_object. So, as the struct is no longer used, delete it.
> 
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---

Applied to drm-misc-next.

Best Regards,
- Maíra Canal

>   drivers/gpu/drm/vgem/vgem_drv.h | 11 -----------
>   1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.h b/drivers/gpu/drm/vgem/vgem_drv.h
> index 0ed300317f87..34cf63e6fb3d 100644
> --- a/drivers/gpu/drm/vgem/vgem_drv.h
> +++ b/drivers/gpu/drm/vgem/vgem_drv.h
> @@ -39,17 +39,6 @@ struct vgem_file {
>   	struct mutex fence_mutex;
>   };
>   
> -#define to_vgem_bo(x) container_of(x, struct drm_vgem_gem_object, base)
> -struct drm_vgem_gem_object {
> -	struct drm_gem_object base;
> -
> -	struct page **pages;
> -	unsigned int pages_pin_count;
> -	struct mutex pages_lock;
> -
> -	struct sg_table *table;
> -};
> -
>   int vgem_fence_open(struct vgem_file *file);
>   int vgem_fence_attach_ioctl(struct drm_device *dev,
>   			    void *data,
diff mbox series

Patch

diff --git a/drivers/gpu/drm/vgem/vgem_drv.h b/drivers/gpu/drm/vgem/vgem_drv.h
index 0ed300317f87..34cf63e6fb3d 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.h
+++ b/drivers/gpu/drm/vgem/vgem_drv.h
@@ -39,17 +39,6 @@  struct vgem_file {
 	struct mutex fence_mutex;
 };
 
-#define to_vgem_bo(x) container_of(x, struct drm_vgem_gem_object, base)
-struct drm_vgem_gem_object {
-	struct drm_gem_object base;
-
-	struct page **pages;
-	unsigned int pages_pin_count;
-	struct mutex pages_lock;
-
-	struct sg_table *table;
-};
-
 int vgem_fence_open(struct vgem_file *file);
 int vgem_fence_attach_ioctl(struct drm_device *dev,
 			    void *data,