| Message ID | 20230228221533.3240520-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/nouveau/fifo: set nvkm_engn_cgrp_get storage-class-specifier to static | expand |
Reviewed-by: Karol Herbst <kherbst@redhat.com> will push in a moment On Tue, Feb 28, 2023 at 11:15 PM Tom Rix <trix@redhat.com> wrote: > > smatch reports > drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:33:18: > warning: symbol 'nvkm_engn_cgrp_get' was not declared. Should it be static? > > nvkm_engn_cgrp_get is only used in runl.c, so it should be static > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c > index b5836cbc29aa..93d628d7d508 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c > @@ -30,7 +30,7 @@ > #include <subdev/timer.h> > #include <subdev/top.h> > > -struct nvkm_cgrp * > +static struct nvkm_cgrp * > nvkm_engn_cgrp_get(struct nvkm_engn *engn, unsigned long *pirqflags) > { > struct nvkm_cgrp *cgrp = NULL; > -- > 2.27.0 >
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c index b5836cbc29aa..93d628d7d508 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c @@ -30,7 +30,7 @@ #include <subdev/timer.h> #include <subdev/top.h> -struct nvkm_cgrp * +static struct nvkm_cgrp * nvkm_engn_cgrp_get(struct nvkm_engn *engn, unsigned long *pirqflags) { struct nvkm_cgrp *cgrp = NULL;
smatch reports drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:33:18: warning: symbol 'nvkm_engn_cgrp_get' was not declared. Should it be static? nvkm_engn_cgrp_get is only used in runl.c, so it should be static Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)