| Message ID | 20230301162508.3963484-1-stanislaw.gruszka@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | accel: Build sub-directories based on config options | expand |
On 3/1/2023 9:25 AM, Stanislaw Gruszka wrote: > When accel drivers are disabled do not process into > sub-directories and create built-in archives: > > AR drivers/accel/habanalabs/built-in.a > AR drivers/accel/ivpu/built-in.a > > Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> Should there be a fixes tag? Feels like something that should be back-ported. Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
On Wed, Mar 01, 2023 at 09:31:10AM -0700, Jeffrey Hugo wrote: > On 3/1/2023 9:25 AM, Stanislaw Gruszka wrote: > > When accel drivers are disabled do not process into > > sub-directories and create built-in archives: > > > > AR drivers/accel/habanalabs/built-in.a > > AR drivers/accel/ivpu/built-in.a > > > > Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> > > Should there be a fixes tag? Feels like something that should be > back-ported. This tag could be added: Fixes: 35b137630f08 ("accel/ivpu: Introduce a new DRM driver for Intel VPU") but since then Makefile changed with habanalabs addition. I expect this will go to drm-misc-fixes and then to linux 6.3-rcX from there, so (stable) back-port will not be needed. Regards Stanislaw
On 3/1/2023 9:53 AM, Stanislaw Gruszka wrote: > On Wed, Mar 01, 2023 at 09:31:10AM -0700, Jeffrey Hugo wrote: >> On 3/1/2023 9:25 AM, Stanislaw Gruszka wrote: >>> When accel drivers are disabled do not process into >>> sub-directories and create built-in archives: >>> >>> AR drivers/accel/habanalabs/built-in.a >>> AR drivers/accel/ivpu/built-in.a >>> >>> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> >> >> Should there be a fixes tag? Feels like something that should be >> back-ported. > > This tag could be added: > > Fixes: 35b137630f08 ("accel/ivpu: Introduce a new DRM driver for Intel VPU") > > but since then Makefile changed with habanalabs addition. > > I expect this will go to drm-misc-fixes and then to linux 6.3-rcX > from there, so (stable) back-port will not be needed. Makes sense. I thought this would apply to 6.2 as well, but it looks like no. -Jeff
Thanks. Applied to drm-misc-next and cherry-picked to drm-misc-fixes. On 01.03.2023 17:53, Stanislaw Gruszka wrote: > On Wed, Mar 01, 2023 at 09:31:10AM -0700, Jeffrey Hugo wrote: >> On 3/1/2023 9:25 AM, Stanislaw Gruszka wrote: >>> When accel drivers are disabled do not process into >>> sub-directories and create built-in archives: >>> >>> AR drivers/accel/habanalabs/built-in.a >>> AR drivers/accel/ivpu/built-in.a >>> >>> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> >> >> Should there be a fixes tag? Feels like something that should be >> back-ported. > > This tag could be added: > > Fixes: 35b137630f08 ("accel/ivpu: Introduce a new DRM driver for Intel VPU") > > but since then Makefile changed with habanalabs addition. > > I expect this will go to drm-misc-fixes and then to linux 6.3-rcX > from there, so (stable) back-port will not be needed. > > Regards > Stanislaw
diff --git a/drivers/accel/Makefile b/drivers/accel/Makefile index 07aa77aed1c8..f22fd44d586b 100644 --- a/drivers/accel/Makefile +++ b/drivers/accel/Makefile @@ -1,4 +1,4 @@ # SPDX-License-Identifier: GPL-2.0-only -obj-y += habanalabs/ -obj-y += ivpu/ +obj-$(CONFIG_DRM_ACCEL_HABANALABS) += habanalabs/ +obj-$(CONFIG_DRM_ACCEL_IVPU) += ivpu/
When accel drivers are disabled do not process into sub-directories and create built-in archives: AR drivers/accel/habanalabs/built-in.a AR drivers/accel/ivpu/built-in.a Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> --- drivers/accel/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)