diff mbox series

[v8,2/2] soc: mediatek: remove DDP_DOMPONENT_DITHER from enum

Message ID 20230306080659.15261-3-jason-jh.lin@mediatek.com (mailing list archive)
State New, archived
Headers show
Series Change mmsys compatible for mt8195 mediatek-drm | expand

Commit Message

Jason-JH Lin (林睿祥) March 6, 2023, 8:06 a.m. UTC 
After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0,
mmsys header can remove the useless DDP_COMPONENT_DITHER enum.

Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
---
 include/linux/soc/mediatek/mtk-mmsys.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Chen-Yu Tsai May 31, 2023, 7:43 a.m. UTC | #1 
Hi Matthias,

On Mon, Mar 6, 2023 at 4:07 PM Jason-JH.Lin <jason-jh.lin@mediatek.com> wrote:
>
> After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0,
> mmsys header can remove the useless DDP_COMPONENT_DITHER enum.
>
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> Acked-by: Matthias Brugger <matthias.bgg@gmail.com>

CK didn't pick up this patch. Since the other patch already got picked up
in v6.4-rc1, could you merge this for v6.5?


Thanks
ChenYu


> ---
>  include/linux/soc/mediatek/mtk-mmsys.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h
> index dc2963a0a0f7..8eb5846985b4 100644
> --- a/include/linux/soc/mediatek/mtk-mmsys.h
> +++ b/include/linux/soc/mediatek/mtk-mmsys.h
> @@ -27,8 +27,7 @@ enum mtk_ddp_comp_id {
>         DDP_COMPONENT_CCORR,
>         DDP_COMPONENT_COLOR0,
>         DDP_COMPONENT_COLOR1,
> -       DDP_COMPONENT_DITHER,
> -       DDP_COMPONENT_DITHER0 = DDP_COMPONENT_DITHER,
> +       DDP_COMPONENT_DITHER0,
>         DDP_COMPONENT_DITHER1,
>         DDP_COMPONENT_DP_INTF0,
>         DDP_COMPONENT_DP_INTF1,
> --
> 2.18.0
>
Matthias Brugger June 9, 2023, 2:41 p.m. UTC | #2 
On 31/05/2023 09:43, Chen-Yu Tsai wrote:
> Hi Matthias,
> 
> On Mon, Mar 6, 2023 at 4:07 PM Jason-JH.Lin <jason-jh.lin@mediatek.com> wrote:
>>
>> After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0,
>> mmsys header can remove the useless DDP_COMPONENT_DITHER enum.
>>
>> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
>> Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
> 
> CK didn't pick up this patch. Since the other patch already got picked up
> in v6.4-rc1, could you merge this for v6.5?
> 

Yes, I gave an acked-by as I thought that CK will take both of them. Anyway 
applied now.

Matthias

> 
> Thanks
> ChenYu
> 
> 
>> ---
>>   include/linux/soc/mediatek/mtk-mmsys.h | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h
>> index dc2963a0a0f7..8eb5846985b4 100644
>> --- a/include/linux/soc/mediatek/mtk-mmsys.h
>> +++ b/include/linux/soc/mediatek/mtk-mmsys.h
>> @@ -27,8 +27,7 @@ enum mtk_ddp_comp_id {
>>          DDP_COMPONENT_CCORR,
>>          DDP_COMPONENT_COLOR0,
>>          DDP_COMPONENT_COLOR1,
>> -       DDP_COMPONENT_DITHER,
>> -       DDP_COMPONENT_DITHER0 = DDP_COMPONENT_DITHER,
>> +       DDP_COMPONENT_DITHER0,
>>          DDP_COMPONENT_DITHER1,
>>          DDP_COMPONENT_DP_INTF0,
>>          DDP_COMPONENT_DP_INTF1,
>> --
>> 2.18.0
>>
diff mbox series

Patch

diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h
index dc2963a0a0f7..8eb5846985b4 100644
--- a/include/linux/soc/mediatek/mtk-mmsys.h
+++ b/include/linux/soc/mediatek/mtk-mmsys.h
@@ -27,8 +27,7 @@  enum mtk_ddp_comp_id {
 	DDP_COMPONENT_CCORR,
 	DDP_COMPONENT_COLOR0,
 	DDP_COMPONENT_COLOR1,
-	DDP_COMPONENT_DITHER,
-	DDP_COMPONENT_DITHER0 = DDP_COMPONENT_DITHER,
+	DDP_COMPONENT_DITHER0,
 	DDP_COMPONENT_DITHER1,
 	DDP_COMPONENT_DP_INTF0,
 	DDP_COMPONENT_DP_INTF1,