| Message ID | 20230310010136.2810776-1-guchun.chen@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,1/2] drm/amdgpu: move poll enabled/disable into non DC path | expand |
[AMD Official Use Only - General] Series is acked-by: Evan Quan <evan.quan@amd.com> > -----Original Message----- > From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of > Guchun Chen > Sent: Friday, March 10, 2023 9:02 AM > To: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > Deucher, Alexander <Alexander.Deucher@amd.com>; Zhang, Hawking > <Hawking.Zhang@amd.com>; dmitry.baryshkov@linaro.org; > spasswolf@web.de; mike@fireburn.co.uk > Cc: Chen, Guchun <Guchun.Chen@amd.com> > Subject: [PATCH v3 2/2] drm/probe_helper: warning on poll_enabled for > issue catching > > In order to catch issues in other drivers to ensure proper call sequence of > polling function. > > v2: drop Fixes tag in commit message > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2411 > Reported-by: Bert Karwatzki <spasswolf@web.de> > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Guchun Chen <guchun.chen@amd.com> > --- > drivers/gpu/drm/drm_probe_helper.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_probe_helper.c > b/drivers/gpu/drm/drm_probe_helper.c > index 8127be134c39..85e0e80d4a52 100644 > --- a/drivers/gpu/drm/drm_probe_helper.c > +++ b/drivers/gpu/drm/drm_probe_helper.c > @@ -852,6 +852,8 @@ EXPORT_SYMBOL(drm_kms_helper_is_poll_worker); > */ > void drm_kms_helper_poll_disable(struct drm_device *dev) { > + WARN_ON(!dev->mode_config.poll_enabled); > + > if (dev->mode_config.poll_running) > drm_kms_helper_disable_hpd(dev); > > -- > 2.25.1
On Fri, 10 Mar 2023, Guchun Chen <guchun.chen@amd.com> wrote: > In order to catch issues in other drivers to ensure proper call > sequence of polling function. > > v2: drop Fixes tag in commit message > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2411 > Reported-by: Bert Karwatzki <spasswolf@web.de> > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Guchun Chen <guchun.chen@amd.com> > --- > drivers/gpu/drm/drm_probe_helper.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c > index 8127be134c39..85e0e80d4a52 100644 > --- a/drivers/gpu/drm/drm_probe_helper.c > +++ b/drivers/gpu/drm/drm_probe_helper.c > @@ -852,6 +852,8 @@ EXPORT_SYMBOL(drm_kms_helper_is_poll_worker); > */ > void drm_kms_helper_poll_disable(struct drm_device *dev) > { > + WARN_ON(!dev->mode_config.poll_enabled); Please address all previous review comments [1]. BR, Jani. [1] https://lore.kernel.org/r/87o7p3bde6.fsf@intel.com > + > if (dev->mode_config.poll_running) > drm_kms_helper_disable_hpd(dev);
> -----Original Message----- > From: Jani Nikula <jani.nikula@linux.intel.com> > Sent: Friday, March 10, 2023 8:05 PM > To: Chen, Guchun <Guchun.Chen@amd.com>; amd- > gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Deucher, > Alexander <Alexander.Deucher@amd.com>; Zhang, Hawking > <Hawking.Zhang@amd.com>; dmitry.baryshkov@linaro.org; > spasswolf@web.de; mike@fireburn.co.uk > Cc: Chen, Guchun <Guchun.Chen@amd.com> > Subject: Re: [PATCH v3 2/2] drm/probe_helper: warning on poll_enabled for > issue catching > > On Fri, 10 Mar 2023, Guchun Chen <guchun.chen@amd.com> wrote: > > In order to catch issues in other drivers to ensure proper call > > sequence of polling function. > > > > v2: drop Fixes tag in commit message > > > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2411 > > Reported-by: Bert Karwatzki <spasswolf@web.de> > > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Signed-off-by: Guchun Chen <guchun.chen@amd.com> > > --- > > drivers/gpu/drm/drm_probe_helper.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_probe_helper.c > > b/drivers/gpu/drm/drm_probe_helper.c > > index 8127be134c39..85e0e80d4a52 100644 > > --- a/drivers/gpu/drm/drm_probe_helper.c > > +++ b/drivers/gpu/drm/drm_probe_helper.c > > @@ -852,6 +852,8 @@ > EXPORT_SYMBOL(drm_kms_helper_is_poll_worker); > > */ > > void drm_kms_helper_poll_disable(struct drm_device *dev) { > > + WARN_ON(!dev->mode_config.poll_enabled); > > Please address all previous review comments [1]. Sorry for missing your previous review email. Will address it in next patch set. Regards, Guchun > BR, > Jani. > > > [1] https://lore.kernel.org/r/87o7p3bde6.fsf@intel.com > > > > + > > if (dev->mode_config.poll_running) > > drm_kms_helper_disable_hpd(dev); > > -- > Jani Nikula, Intel Open Source Graphics Center
diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c index 8127be134c39..85e0e80d4a52 100644 --- a/drivers/gpu/drm/drm_probe_helper.c +++ b/drivers/gpu/drm/drm_probe_helper.c @@ -852,6 +852,8 @@ EXPORT_SYMBOL(drm_kms_helper_is_poll_worker); */ void drm_kms_helper_poll_disable(struct drm_device *dev) { + WARN_ON(!dev->mode_config.poll_enabled); + if (dev->mode_config.poll_running) drm_kms_helper_disable_hpd(dev);
In order to catch issues in other drivers to ensure proper call sequence of polling function. v2: drop Fixes tag in commit message Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2411 Reported-by: Bert Karwatzki <spasswolf@web.de> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Guchun Chen <guchun.chen@amd.com> --- drivers/gpu/drm/drm_probe_helper.c | 2 ++ 1 file changed, 2 insertions(+)