| Message ID | 20230316113640.499267-7-ogabbay@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/10] accel/habanalabs: align to latest firmware specs | expand |
On 16/03/2023 13:36, Oded Gabbay wrote: > Don't use padX for actual reservedX fields. > > Signed-off-by: Oded Gabbay <ogabbay@kernel.org> > --- > include/uapi/drm/habanalabs_accel.h | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/include/uapi/drm/habanalabs_accel.h b/include/uapi/drm/habanalabs_accel.h > index 7ca0ef802fd1..7d457eb4da74 100644 > --- a/include/uapi/drm/habanalabs_accel.h > +++ b/include/uapi/drm/habanalabs_accel.h > @@ -915,17 +915,18 @@ struct hl_info_hw_ip_info { > __u64 dram_page_size; > __u32 edma_enabled_mask; > __u16 number_of_user_interrupts; > - __u16 pad2; > - __u64 reserved4; > + __u8 reserved1; > + __u8 reserved2; > + __u64 reserved3; > __u64 device_mem_alloc_default_page_size; > + __u64 reserved4; > __u64 reserved5; > - __u64 reserved6; > - __u32 reserved7; > - __u8 reserved8; > + __u32 reserved6; > + __u8 reserved7; > __u8 revision_id; > __u16 tpc_interrupt_id; > + __u32 reserved8; > __u32 reserved9; > - __u8 pad3[4]; > __u64 engine_core_interrupt_reg_addr; > }; > Reviewed-by: Ofir Bitton <obitton@habana.ai>
diff --git a/include/uapi/drm/habanalabs_accel.h b/include/uapi/drm/habanalabs_accel.h index 7ca0ef802fd1..7d457eb4da74 100644 --- a/include/uapi/drm/habanalabs_accel.h +++ b/include/uapi/drm/habanalabs_accel.h @@ -915,17 +915,18 @@ struct hl_info_hw_ip_info { __u64 dram_page_size; __u32 edma_enabled_mask; __u16 number_of_user_interrupts; - __u16 pad2; - __u64 reserved4; + __u8 reserved1; + __u8 reserved2; + __u64 reserved3; __u64 device_mem_alloc_default_page_size; + __u64 reserved4; __u64 reserved5; - __u64 reserved6; - __u32 reserved7; - __u8 reserved8; + __u32 reserved6; + __u8 reserved7; __u8 revision_id; __u16 tpc_interrupt_id; + __u32 reserved8; __u32 reserved9; - __u8 pad3[4]; __u64 engine_core_interrupt_reg_addr; };
Don't use padX for actual reservedX fields. Signed-off-by: Oded Gabbay <ogabbay@kernel.org> --- include/uapi/drm/habanalabs_accel.h | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)