| Message ID | 20230318221027.260115-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | drm/imx/lcdc: Fix compilation with CONFIG_OF=n | expand |
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes: Hello Uwe, > Hello, > > On Sat, Mar 18, 2023 at 11:10:27PM +0100, Uwe Kleine-König wrote: >> The driver needs the include <drm/drm_bridge.h>. WIth CONFIG_OF enabled > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> > Just noticed: s/WIth/With/. Assuming no further review comments make a > v2 necessary: Should I resend for that, or can you fixup when you apply > this patch? > No need to resend, I'll fix it when pushing to drm-misc-next.
Javier Martinez Canillas <javierm@redhat.com> writes: > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes: > > Hello Uwe, > >> Hello, >> >> On Sat, Mar 18, 2023 at 11:10:27PM +0100, Uwe Kleine-König wrote: >>> The driver needs the include <drm/drm_bridge.h>. WIth CONFIG_OF enabled >> > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> > > >> Just noticed: s/WIth/With/. Assuming no further review comments make a >> v2 necessary: Should I resend for that, or can you fixup when you apply >> this patch? >> > > No need to resend, I'll fix it when pushing to drm-misc-next. > This issue was already fixed by Dave in commit b24343eaceed ("Merge tag 'drm-misc-next-2023-03-16' of git://anongit.freedesktop.org/drm/drm-misc into drm-next").
Hello Javier, On Sat, Apr 15, 2023 at 11:47:22PM +0200, Javier Martinez Canillas wrote: > Javier Martinez Canillas <javierm@redhat.com> writes: > > > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes: > > > > Hello Uwe, > > > >> Hello, > >> > >> On Sat, Mar 18, 2023 at 11:10:27PM +0100, Uwe Kleine-König wrote: > >>> The driver needs the include <drm/drm_bridge.h>. WIth CONFIG_OF enabled > >> > > > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> > > > > > >> Just noticed: s/WIth/With/. Assuming no further review comments make a > >> v2 necessary: Should I resend for that, or can you fixup when you apply > >> this patch? > >> > > > > No need to resend, I'll fix it when pushing to drm-misc-next. > > > > This issue was already fixed by Dave in commit b24343eaceed ("Merge tag > 'drm-misc-next-2023-03-16' of git://anongit.freedesktop.org/drm/drm-misc > into drm-next"). FTR: s/b24343eaceed/c6265f5c2f50/ Thanks for looking into this, and also the other patch for imx-lcdc! Best regards Uwe
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes: [...] >> >> This issue was already fixed by Dave in commit b24343eaceed ("Merge tag >> 'drm-misc-next-2023-03-16' of git://anongit.freedesktop.org/drm/drm-misc >> into drm-next"). > > FTR: s/b24343eaceed/c6265f5c2f50/ > Ups indeed. I pasted the wrong commit :) > Thanks for looking into this, and also the other patch for imx-lcdc! > You are welcome!
diff --git a/drivers/gpu/drm/imx/lcdc/imx-lcdc.c b/drivers/gpu/drm/imx/lcdc/imx-lcdc.c index 24bc7b310367..8e6d457917da 100644 --- a/drivers/gpu/drm/imx/lcdc/imx-lcdc.c +++ b/drivers/gpu/drm/imx/lcdc/imx-lcdc.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0-only // SPDX-FileCopyrightText: 2020 Marian Cichy <M.Cichy@pengutronix.de> +#include <drm/drm_bridge.h> #include <drm/drm_bridge_connector.h> #include <drm/drm_damage_helper.h> #include <drm/drm_drv.h>
The driver needs the include <drm/drm_bridge.h>. WIth CONFIG_OF enabled this is provided by a conditional include in <drm/drm_of.h>. To fix building the lcdc driver with CONFIG_OF=n, include <drm/drm_bridge.h> explicitly. Fixes: c87e859cdeb5 ("drm/imx/lcdc: Implement DRM driver for imx25") Reported-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/oe-kbuild-all/202303190127.uylmokJl-lkp@intel.com/ Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/gpu/drm/imx/lcdc/imx-lcdc.c | 1 + 1 file changed, 1 insertion(+) base-commit: c87e859cdeb5d106cb861326e3135c606d61f88d