From patchwork Wed Mar 22 17:02:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13184341 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74C5CC6FD1C for ; Wed, 22 Mar 2023 17:02:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D12FD10E9A3; Wed, 22 Mar 2023 17:02:32 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 859E510E3E9 for ; Wed, 22 Mar 2023 17:02:30 +0000 (UTC) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pf1r1-0000PU-Rp; Wed, 22 Mar 2023 18:02:27 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pf1r1-005xjx-4z; Wed, 22 Mar 2023 18:02:27 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pf1r0-0075pT-Do; Wed, 22 Mar 2023 18:02:26 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , David Airlie , Daniel Vetter , Jonathan Hunter Subject: [PATCH 03/12] drm/tegra: dc: Convert to platform remove callback returning void Date: Wed, 22 Mar 2023 18:02:14 +0100 Message-Id: <20230322170223.410376-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230322170223.410376-1-u.kleine-koenig@pengutronix.de> References: <20230322170223.410376-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1624; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=8CVItIwYzK3rZXS6aH5yKeL14hWmec5ZIR7iH6JSpuE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkGzSRgRx7UW6hEDVhHgcaH8qbMVTrkfZhaYsv+ NzFaTOuQG2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZBs0kQAKCRCPgPtYfRL+ ThmsCACzElK1kL3IKjcabYXCE+AFMFWhTfA3Jh3Lf3REWp/8nIKq23DZ5S3g9dF6I2wy2ByuQSs ss3qNUyp90/hU/5M7B6A78x3i4olxQKlMZWAQwE9YXI6TDQPGFysL4EmPi/UjbX7v3C8AXtqFib CU0NND3yAHNMZO5wKFzd4MMSTf+BMnKuQsx+u1/0W8JUt1V/El5KaifdLhL9OxZdSOiDuqjoGcd HxaKLYB84ypwUSGqOaSciTo85kh6m+a7ipAFGLfOcgoyPo+btvqA5/BxE7EwQexV4phhnjIwUzl ik0sOCg3MeLWAdfdpfnyCoUg0DMyhaVIXJ9aZoSIL8qOC7em X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, kernel@pengutronix.de, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/tegra/dc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index 6bf1b2bc43b1..53630b673029 100644 --- a/drivers/gpu/drm/tegra/dc.c +++ b/drivers/gpu/drm/tegra/dc.c @@ -3263,7 +3263,7 @@ static int tegra_dc_probe(struct platform_device *pdev) return err; } -static int tegra_dc_remove(struct platform_device *pdev) +static void tegra_dc_remove(struct platform_device *pdev) { struct tegra_dc *dc = platform_get_drvdata(pdev); @@ -3272,8 +3272,6 @@ static int tegra_dc_remove(struct platform_device *pdev) tegra_dc_rgb_remove(dc); pm_runtime_disable(&pdev->dev); - - return 0; } struct platform_driver tegra_dc_driver = { @@ -3282,5 +3280,5 @@ struct platform_driver tegra_dc_driver = { .of_match_table = tegra_dc_of_match, }, .probe = tegra_dc_probe, - .remove = tegra_dc_remove, + .remove_new = tegra_dc_remove, };