From patchwork Wed Mar 22 17:02:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13184350 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4640DC6FD1F for ; Wed, 22 Mar 2023 17:03:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4C42F10E9AA; Wed, 22 Mar 2023 17:03:16 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2BE5A10E99B for ; Wed, 22 Mar 2023 17:02:33 +0000 (UTC) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pf1r2-0000QW-R3; Wed, 22 Mar 2023 18:02:28 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pf1r2-005xkC-4G; Wed, 22 Mar 2023 18:02:28 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pf1r1-0075pj-9s; Wed, 22 Mar 2023 18:02:27 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , David Airlie , Daniel Vetter , Jonathan Hunter Subject: [PATCH 07/12] drm/tegra: gr3d: Convert to platform remove callback returning void Date: Wed, 22 Mar 2023 18:02:18 +0100 Message-Id: <20230322170223.410376-8-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230322170223.410376-1-u.kleine-koenig@pengutronix.de> References: <20230322170223.410376-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1518; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=3s7091uswwQh/HJIfWJ5QGHqkE8sp2LfyGJsXRXhH+M=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkGzSWStaawCYKwI/0EiwcUCI+HOXVdsNGa8rjq oI1s/4IglyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZBs0lgAKCRCPgPtYfRL+ Thy6CACbKJGkVT9IDeZkpiQppEbjMGRAxJvGQzbZCB+ZSP9hULuW5c/ogpaqvDLg4iqhvOMEHet xyp7GHW6rW3lnw7gCScELJNUHzX5NJTi+mZP6jUqB6+N4pGKFiCUAm1UHKy2gD/sOYEz1OGI3ow S9e3Jl4rCh7i4xMoyVIiRxpzC+faMJhM9eVZbIXyKebxbBkrtTCLLhFb3WKv8K+BDt4z1MtJdcb EVDOeJ0qy7XsDUKYTFMhE9aBftcV59riy2jRzif2tzPTN7LP6DcIX8CfcJ008TrLyiwKqLstPk5 5qgaWL/3dRaO/u8x23iV8ZdHd6CF0aYQbgce7cpEJukhrxiq X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, kernel@pengutronix.de, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/tegra/gr3d.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/gr3d.c b/drivers/gpu/drm/tegra/gr3d.c index cd3679d8eef9..c026c2c916c1 100644 --- a/drivers/gpu/drm/tegra/gr3d.c +++ b/drivers/gpu/drm/tegra/gr3d.c @@ -550,13 +550,11 @@ static int gr3d_probe(struct platform_device *pdev) return 0; } -static int gr3d_remove(struct platform_device *pdev) +static void gr3d_remove(struct platform_device *pdev) { struct gr3d *gr3d = platform_get_drvdata(pdev); host1x_client_unregister(&gr3d->client.base); - - return 0; } static int __maybe_unused gr3d_runtime_suspend(struct device *dev) @@ -632,5 +630,5 @@ struct platform_driver tegra_gr3d_driver = { .pm = &tegra_gr3d_pm, }, .probe = gr3d_probe, - .remove = gr3d_remove, + .remove_new = gr3d_remove, };