| Message ID | 20230329-rfc-msm-dsc-helper-v11-5-30270e1eeac3@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduce MSM-specific DSC helpers | expand |
On 2023-05-17 11:51:14, Jessica Zhang wrote: > Introduce MSM-specific DSC helper methods, as some calculations are > common between DP and DSC. > > Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> > --- > drivers/gpu/drm/msm/msm_dsc_helper.h | 38 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_dsc_helper.h b/drivers/gpu/drm/msm/msm_dsc_helper.h > new file mode 100644 > index 000000000000..2d366ec7d92d > --- /dev/null > +++ b/drivers/gpu/drm/msm/msm_dsc_helper.h > @@ -0,0 +1,38 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved > + * > + * Helper methods for MSM specific DSC calculations that are common between timing engine, Nit following the commit body: MSM-specific with a hyphen. > + * DSI, and DP. > + */ > + > +#ifndef MSM_DSC_HELPER_H_ > +#define MSM_DSC_HELPER_H_ > + > +#include <linux/math.h> > +#include <drm/display/drm_dsc_helper.h> > + > +/** > + * msm_dsc_get_slices_per_intf() - get number of slices per interface get -> calculate? > + * @dsc: Pointer to drm dsc config struct > + * @intf_width: interface width in pixels > + * Returns: Integer representing the number of slices for the given interface > + */ > +static inline int msm_dsc_get_slices_per_intf(const struct drm_dsc_config *dsc, int intf_width) u32 per v10 review and acks? The rest looks good, thanks! - Marijn > +{ > + return DIV_ROUND_UP(intf_width, dsc->slice_width); > +} > + > +/** > + * msm_dsc_get_bytes_per_line() - calculate bytes per line > + * @dsc: Pointer to drm dsc config struct > + * Returns: Integer value representing bytes per line. DSI and DP need > + * to perform further calculations to turn this into pclk_per_intf, > + * such as dividing by different values depending on if widebus is enabled. > + */ > +static inline u32 msm_dsc_get_bytes_per_line(const struct drm_dsc_config *dsc) > +{ > + return dsc->slice_count * dsc->slice_chunk_size; > +} > + > +#endif /* MSM_DSC_HELPER_H_ */ > > -- > 2.40.1 >
On 5/17/2023 2:26 PM, Marijn Suijten wrote: > On 2023-05-17 11:51:14, Jessica Zhang wrote: >> Introduce MSM-specific DSC helper methods, as some calculations are >> common between DP and DSC. >> >> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> >> --- >> drivers/gpu/drm/msm/msm_dsc_helper.h | 38 ++++++++++++++++++++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> >> diff --git a/drivers/gpu/drm/msm/msm_dsc_helper.h b/drivers/gpu/drm/msm/msm_dsc_helper.h >> new file mode 100644 >> index 000000000000..2d366ec7d92d >> --- /dev/null >> +++ b/drivers/gpu/drm/msm/msm_dsc_helper.h >> @@ -0,0 +1,38 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved >> + * >> + * Helper methods for MSM specific DSC calculations that are common between timing engine, > > Nit following the commit body: MSM-specific with a hyphen. Hi Marijn, Acked. > >> + * DSI, and DP. >> + */ >> + >> +#ifndef MSM_DSC_HELPER_H_ >> +#define MSM_DSC_HELPER_H_ >> + >> +#include <linux/math.h> >> +#include <drm/display/drm_dsc_helper.h> >> + >> +/** >> + * msm_dsc_get_slices_per_intf() - get number of slices per interface > > get -> calculate? Acked. > >> + * @dsc: Pointer to drm dsc config struct >> + * @intf_width: interface width in pixels >> + * Returns: Integer representing the number of slices for the given interface >> + */ >> +static inline int msm_dsc_get_slices_per_intf(const struct drm_dsc_config *dsc, int intf_width) > > u32 per v10 review and acks? Ah, must have missed this one. Thanks, Jessica Zhang > > The rest looks good, thanks! > > - Marijn > >> +{ >> + return DIV_ROUND_UP(intf_width, dsc->slice_width); >> +} >> + >> +/** >> + * msm_dsc_get_bytes_per_line() - calculate bytes per line >> + * @dsc: Pointer to drm dsc config struct >> + * Returns: Integer value representing bytes per line. DSI and DP need >> + * to perform further calculations to turn this into pclk_per_intf, >> + * such as dividing by different values depending on if widebus is enabled. >> + */ >> +static inline u32 msm_dsc_get_bytes_per_line(const struct drm_dsc_config *dsc) >> +{ >> + return dsc->slice_count * dsc->slice_chunk_size; >> +} >> + >> +#endif /* MSM_DSC_HELPER_H_ */ >> >> -- >> 2.40.1 >>
diff --git a/drivers/gpu/drm/msm/msm_dsc_helper.h b/drivers/gpu/drm/msm/msm_dsc_helper.h new file mode 100644 index 000000000000..2d366ec7d92d --- /dev/null +++ b/drivers/gpu/drm/msm/msm_dsc_helper.h @@ -0,0 +1,38 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved + * + * Helper methods for MSM specific DSC calculations that are common between timing engine, + * DSI, and DP. + */ + +#ifndef MSM_DSC_HELPER_H_ +#define MSM_DSC_HELPER_H_ + +#include <linux/math.h> +#include <drm/display/drm_dsc_helper.h> + +/** + * msm_dsc_get_slices_per_intf() - get number of slices per interface + * @dsc: Pointer to drm dsc config struct + * @intf_width: interface width in pixels + * Returns: Integer representing the number of slices for the given interface + */ +static inline int msm_dsc_get_slices_per_intf(const struct drm_dsc_config *dsc, int intf_width) +{ + return DIV_ROUND_UP(intf_width, dsc->slice_width); +} + +/** + * msm_dsc_get_bytes_per_line() - calculate bytes per line + * @dsc: Pointer to drm dsc config struct + * Returns: Integer value representing bytes per line. DSI and DP need + * to perform further calculations to turn this into pclk_per_intf, + * such as dividing by different values depending on if widebus is enabled. + */ +static inline u32 msm_dsc_get_bytes_per_line(const struct drm_dsc_config *dsc) +{ + return dsc->slice_count * dsc->slice_chunk_size; +} + +#endif /* MSM_DSC_HELPER_H_ */
Introduce MSM-specific DSC helper methods, as some calculations are common between DP and DSC. Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> --- drivers/gpu/drm/msm/msm_dsc_helper.h | 38 ++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+)