| Message ID | 20230330083607.12834-2-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/tegra: Convert fbdev to DRM client | expand |
Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn <mailto:suijingfeng@loongson.cn>> On 2023/3/30 16:36, Thomas Zimmermann wrote: > Include <linux/of.h> to get the contained declarations. No functional > changes. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > drivers/gpu/drm/tegra/output.c | 2 ++ > drivers/gpu/drm/tegra/rgb.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c > index a8925dcd7edd..d31c87f48da0 100644 > --- a/drivers/gpu/drm/tegra/output.c > +++ b/drivers/gpu/drm/tegra/output.c > @@ -4,6 +4,8 @@ > * Copyright (C) 2012 NVIDIA CORPORATION. All rights reserved. > */ > > +#include <linux/of.h> > + > #include <drm/drm_atomic_helper.h> > #include <drm/drm_of.h> > #include <drm/drm_panel.h> > diff --git a/drivers/gpu/drm/tegra/rgb.c b/drivers/gpu/drm/tegra/rgb.c > index ff8fce36d2aa..3f060282cd8d 100644 > --- a/drivers/gpu/drm/tegra/rgb.c > +++ b/drivers/gpu/drm/tegra/rgb.c > @@ -5,6 +5,7 @@ > */ > > #include <linux/clk.h> > +#include <linux/of.h> > > #include <drm/drm_atomic_helper.h> > #include <drm/drm_bridge_connector.h>
Am 30.03.23 um 14:51 schrieb Sui Jingfeng: > > Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn > <mailto:suijingfeng@loongson.cn>> Thanks a lot. > > > On 2023/3/30 16:36, Thomas Zimmermann wrote: >> Include <linux/of.h> to get the contained declarations. No functional >> changes. >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >> --- >> drivers/gpu/drm/tegra/output.c | 2 ++ >> drivers/gpu/drm/tegra/rgb.c | 1 + >> 2 files changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/tegra/output.c >> b/drivers/gpu/drm/tegra/output.c >> index a8925dcd7edd..d31c87f48da0 100644 >> --- a/drivers/gpu/drm/tegra/output.c >> +++ b/drivers/gpu/drm/tegra/output.c >> @@ -4,6 +4,8 @@ >> * Copyright (C) 2012 NVIDIA CORPORATION. All rights reserved. >> */ >> +#include <linux/of.h> >> + >> #include <drm/drm_atomic_helper.h> >> #include <drm/drm_of.h> >> #include <drm/drm_panel.h> >> diff --git a/drivers/gpu/drm/tegra/rgb.c b/drivers/gpu/drm/tegra/rgb.c >> index ff8fce36d2aa..3f060282cd8d 100644 >> --- a/drivers/gpu/drm/tegra/rgb.c >> +++ b/drivers/gpu/drm/tegra/rgb.c >> @@ -5,6 +5,7 @@ >> */ >> #include <linux/clk.h> >> +#include <linux/of.h> >> #include <drm/drm_atomic_helper.h> >> #include <drm/drm_bridge_connector.h>
Hi, On 2023/4/3 18:42, Thomas Zimmermann wrote: > > > Am 30.03.23 um 14:51 schrieb Sui Jingfeng: >> >> Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn >> <mailto:suijingfeng@loongson.cn>> > > Thanks a lot. > I send my mail with Thunderbird mail client, don't know this does this look like this. Sorry about that. It should be: Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn> Please correct it manually, others patches also look good to me. Yet, it beyond my ability to review, I still digging your patch and learning from it. :) >> >> >> On 2023/3/30 16:36, Thomas Zimmermann wrote: >>> Include <linux/of.h> to get the contained declarations. No functional >>> changes. >>> >>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >>> --- >>> drivers/gpu/drm/tegra/output.c | 2 ++ >>> drivers/gpu/drm/tegra/rgb.c | 1 + >>> 2 files changed, 3 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/tegra/output.c >>> b/drivers/gpu/drm/tegra/output.c >>> index a8925dcd7edd..d31c87f48da0 100644 >>> --- a/drivers/gpu/drm/tegra/output.c >>> +++ b/drivers/gpu/drm/tegra/output.c >>> @@ -4,6 +4,8 @@ >>> * Copyright (C) 2012 NVIDIA CORPORATION. All rights reserved. >>> */ >>> +#include <linux/of.h> >>> + >>> #include <drm/drm_atomic_helper.h> >>> #include <drm/drm_of.h> >>> #include <drm/drm_panel.h> >>> diff --git a/drivers/gpu/drm/tegra/rgb.c b/drivers/gpu/drm/tegra/rgb.c >>> index ff8fce36d2aa..3f060282cd8d 100644 >>> --- a/drivers/gpu/drm/tegra/rgb.c >>> +++ b/drivers/gpu/drm/tegra/rgb.c >>> @@ -5,6 +5,7 @@ >>> */ >>> #include <linux/clk.h> >>> +#include <linux/of.h> >>> #include <drm/drm_atomic_helper.h> >>> #include <drm/drm_bridge_connector.h> >
diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c index a8925dcd7edd..d31c87f48da0 100644 --- a/drivers/gpu/drm/tegra/output.c +++ b/drivers/gpu/drm/tegra/output.c @@ -4,6 +4,8 @@ * Copyright (C) 2012 NVIDIA CORPORATION. All rights reserved. */ +#include <linux/of.h> + #include <drm/drm_atomic_helper.h> #include <drm/drm_of.h> #include <drm/drm_panel.h> diff --git a/drivers/gpu/drm/tegra/rgb.c b/drivers/gpu/drm/tegra/rgb.c index ff8fce36d2aa..3f060282cd8d 100644 --- a/drivers/gpu/drm/tegra/rgb.c +++ b/drivers/gpu/drm/tegra/rgb.c @@ -5,6 +5,7 @@ */ #include <linux/clk.h> +#include <linux/of.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_bridge_connector.h>
Include <linux/of.h> to get the contained declarations. No functional changes. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/tegra/output.c | 2 ++ drivers/gpu/drm/tegra/rgb.c | 1 + 2 files changed, 3 insertions(+)