| Message ID | 20230414125913.851920-1-broonie@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | linux-next: manual merge of the drm-misc tree with the mm-stable tree | expand |
On Fri, Apr 14, 2023 at 01:59:12PM +0100, broonie@kernel.org wrote: > Hi all, > > Today's linux-next merge of the drm-misc tree got a conflict in: > > drivers/gpu/drm/ttm/ttm_pool.c > > between commit: > > 23baf831a32c0 ("mm, treewide: redefine MAX_ORDER sanely") > > from the mm-stable tree and commit: > > 56e51681246e5 ("drm/ttm: revert "Reduce the number of used allocation orders for TTM pages"") > > from the drm-misc tree. > > I fixed it up (see below) and can carry the fix as necessary. This > is now fixed as far as linux-next is concerned, but any non trivial > conflicts should be mentioned to your upstream maintainer when your tree > is submitted for merging. You may also want to consider cooperating > with the maintainer of the conflicting tree to minimise any particularly > complex conflicts. > > > diff --cc drivers/gpu/drm/ttm/ttm_pool.c > index 4db3982057be8,dfce896c4baeb..0000000000000 > --- a/drivers/gpu/drm/ttm/ttm_pool.c > +++ b/drivers/gpu/drm/ttm/ttm_pool.c > > [Just the version in mm] Note there was a ppc compile fail, which is why we pushed the ttm revert. That /should/ be fixed now, but would be good if you can confirm? Thanks, Daniel
On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: > Note there was a ppc compile fail, which is why we pushed the ttm revert. > That /should/ be fixed now, but would be good if you can confirm? I don't have any PowerPC toolchains set up - I guess one of the community builders might have checked?
On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: > Note there was a ppc compile fail, which is why we pushed the ttm revert. > That /should/ be fixed now, but would be good if you can confirm? According to Nathan (CCed) there's still issues with the interaction with the PowerPC tree.
On Tue, Apr 18, 2023 at 07:34:44PM +0100, Mark Brown wrote: > On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: > > > Note there was a ppc compile fail, which is why we pushed the ttm revert. > > That /should/ be fixed now, but would be good if you can confirm? > > According to Nathan (CCed) there's still issues with the interaction > with the PowerPC tree. So this revert was supposed to fix this: 56e51681246e ("drm/ttm: revert "Reduce the number of used allocation orders for TTM pages"") If there's anything left then I need to chase that asap since the merge window will open soon. -Daniel
On Wed, Apr 19, 2023 at 06:24:37PM +0200, Daniel Vetter wrote: > On Tue, Apr 18, 2023 at 07:34:44PM +0100, Mark Brown wrote: > > On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: > > > > > Note there was a ppc compile fail, which is why we pushed the ttm revert. > > > That /should/ be fixed now, but would be good if you can confirm? > > > > According to Nathan (CCed) there's still issues with the interaction > > with the PowerPC tree. > > So this revert was supposed to fix this: 56e51681246e ("drm/ttm: revert > "Reduce the number of used allocation orders for TTM pages"") > > If there's anything left then I need to chase that asap since the merge > window will open soon. I think we are talking about two different issues here. My issue is not a compilation failure, it is an incorrect merge resolution that is happening in -next because of two independent changes in the drm and powerpc tree, the thread below should have more information. https://lore.kernel.org/20230413184725.GA3183133@dev-arch.thelio-3990X/ I do not think this is something that either tree can solve independently of each other, -next has to resolve the conflict correctly (which is what I point out in the message above) and a note of it should be passed along to Linus so it can be resolved correctly in mainline when the time comes. Cheers, Nathan
On Wed, Apr 19, 2023 at 09:30:11AM -0700, Nathan Chancellor wrote: > On Wed, Apr 19, 2023 at 06:24:37PM +0200, Daniel Vetter wrote: > > On Tue, Apr 18, 2023 at 07:34:44PM +0100, Mark Brown wrote: > > > On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: > > > > > > > Note there was a ppc compile fail, which is why we pushed the ttm revert. > > > > That /should/ be fixed now, but would be good if you can confirm? > > > > > > According to Nathan (CCed) there's still issues with the interaction > > > with the PowerPC tree. > > > > So this revert was supposed to fix this: 56e51681246e ("drm/ttm: revert > > "Reduce the number of used allocation orders for TTM pages"") > > > > If there's anything left then I need to chase that asap since the merge > > window will open soon. > > I think we are talking about two different issues here. My issue is not > a compilation failure, it is an incorrect merge resolution that is > happening in -next because of two independent changes in the drm and > powerpc tree, the thread below should have more information. > > https://lore.kernel.org/20230413184725.GA3183133@dev-arch.thelio-3990X/ > > I do not think this is something that either tree can solve > independently of each other, -next has to resolve the conflict correctly > (which is what I point out in the message above) and a note of it should > be passed along to Linus so it can be resolved correctly in mainline > when the time comes. Ah yes that's a different one. I think we have a note about this one already, but I'll double-check with Dave Airlie. -Daniel
diff --cc drivers/gpu/drm/ttm/ttm_pool.c index 4db3982057be8,dfce896c4baeb..0000000000000 --- a/drivers/gpu/drm/ttm/ttm_pool.c
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/ttm/ttm_pool.c between commit: 23baf831a32c0 ("mm, treewide: redefine MAX_ORDER sanely") from the mm-stable tree and commit: 56e51681246e5 ("drm/ttm: revert "Reduce the number of used allocation orders for TTM pages"") from the drm-misc tree. I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. +++ b/drivers/gpu/drm/ttm/ttm_pool.c [Just the version in mm]