From patchwork Tue Apr 25 15:13:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Artemiev X-Patchwork-Id: 13224185 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 829FAC7618E for ; Wed, 26 Apr 2023 07:37:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E32B310E2E1; Wed, 26 Apr 2023 07:37:00 +0000 (UTC) Received: from tretyak2.mcst.ru (tretyak2.mcst.ru [212.5.119.215]) by gabe.freedesktop.org (Postfix) with ESMTPS id C419A10E063; Tue, 25 Apr 2023 15:14:40 +0000 (UTC) Received: from tretyak2.mcst.ru (localhost [127.0.0.1]) by tretyak2.mcst.ru (Postfix) with ESMTP id 940E810239C; Tue, 25 Apr 2023 18:14:34 +0300 (MSK) Received: from frog.lab.sun.mcst.ru (frog.lab.sun.mcst.ru [172.16.4.50]) by tretyak2.mcst.ru (Postfix) with ESMTP id 8EDEC10239E; Tue, 25 Apr 2023 18:13:49 +0300 (MSK) Received: from artemiev-i.lab.sun.mcst.ru (avior-1 [192.168.53.223]) by frog.lab.sun.mcst.ru (8.13.4/8.12.11) with ESMTP id 33PFDm1r001729; Tue, 25 Apr 2023 18:13:48 +0300 From: Igor Artemiev To: David Airlie Subject: [lvc-project] [PATCH] drm/radeon: remove useless conditions Date: Tue, 25 Apr 2023 18:13:18 +0300 Message-Id: <20230425151318.561432-1-Igor.A.Artemiev@mcst.ru> X-Mailer: git-send-email 2.39.0.152.ga5737674b6 MIME-Version: 1.0 X-Anti-Virus: Kaspersky Anti-Virus for Linux Mail Server 5.6.39/RELEASE, bases: 20111107 #2745587, check: 20230425 notchecked X-AV-Checked: ClamAV using ClamSMTP X-Mailman-Approved-At: Wed, 26 Apr 2023 07:36:59 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvc-project@linuxtesting.org, "Pan, Xinhui" , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Igor Artemiev , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Comparisons of 'table' and 'vddc_sclk_table' with NULL are useless since 'table' and 'vddc_sclk_table' are initialized by an addresses and cannot be NULL. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Igor Artemiev --- drivers/gpu/drm/radeon/kv_dpm.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/radeon/kv_dpm.c b/drivers/gpu/drm/radeon/kv_dpm.c index f7735da07feb..17d312ceb6ec 100644 --- a/drivers/gpu/drm/radeon/kv_dpm.c +++ b/drivers/gpu/drm/radeon/kv_dpm.c @@ -399,7 +399,7 @@ static u32 kv_convert_vid2_to_vid7(struct radeon_device *rdev, &rdev->pm.dpm.dyn_state.vddc_dependency_on_sclk; u32 i; - if (vddc_sclk_table && vddc_sclk_table->count) { + if (vddc_sclk_table->count) { if (vid_2bit < vddc_sclk_table->count) return vddc_sclk_table->entries[vid_2bit].v; else @@ -421,7 +421,7 @@ static u32 kv_convert_vid7_to_vid2(struct radeon_device *rdev, &rdev->pm.dpm.dyn_state.vddc_dependency_on_sclk; u32 i; - if (vddc_sclk_table && vddc_sclk_table->count) { + if (vddc_sclk_table->count) { for (i = 0; i < vddc_sclk_table->count; i++) { if (vddc_sclk_table->entries[i].v == vid_7bit) return i; @@ -561,7 +561,7 @@ static int kv_program_bootup_state(struct radeon_device *rdev) struct radeon_clock_voltage_dependency_table *table = &rdev->pm.dpm.dyn_state.vddc_dependency_on_sclk; - if (table && table->count) { + if (table->count) { for (i = pi->graphics_dpm_level_count - 1; i > 0; i--) { if (table->entries[i].clk == pi->boot_pl.sclk) break; @@ -666,7 +666,7 @@ static int kv_populate_uvd_table(struct radeon_device *rdev) int ret; u32 i; - if (table == NULL || table->count == 0) + if (table->count == 0) return 0; pi->uvd_level_count = 0; @@ -737,7 +737,7 @@ static int kv_populate_vce_table(struct radeon_device *rdev) &rdev->pm.dpm.dyn_state.vce_clock_voltage_dependency_table; struct atom_clock_dividers dividers; - if (table == NULL || table->count == 0) + if (table->count == 0) return 0; pi->vce_level_count = 0; @@ -800,7 +800,7 @@ static int kv_populate_samu_table(struct radeon_device *rdev) int ret; u32 i; - if (table == NULL || table->count == 0) + if (table->count == 0) return 0; pi->samu_level_count = 0; @@ -866,7 +866,7 @@ static int kv_populate_acp_table(struct radeon_device *rdev) int ret; u32 i; - if (table == NULL || table->count == 0) + if (table->count == 0) return 0; pi->acp_level_count = 0; @@ -922,7 +922,7 @@ static void kv_calculate_dfs_bypass_settings(struct radeon_device *rdev) struct radeon_clock_voltage_dependency_table *table = &rdev->pm.dpm.dyn_state.vddc_dependency_on_sclk; - if (table && table->count) { + if (table->count) { for (i = 0; i < pi->graphics_dpm_level_count; i++) { if (pi->caps_enable_dfs_bypass) { if (kv_get_clock_difference(table->entries[i].clk, 40000) < 200) @@ -1532,7 +1532,7 @@ static void kv_set_valid_clock_range(struct radeon_device *rdev, struct radeon_clock_voltage_dependency_table *table = &rdev->pm.dpm.dyn_state.vddc_dependency_on_sclk; - if (table && table->count) { + if (table->count) { for (i = 0; i < pi->graphics_dpm_level_count; i++) { if ((table->entries[i].clk >= new_ps->levels[0].sclk) || (i == (pi->graphics_dpm_level_count - 1))) { @@ -1905,7 +1905,7 @@ static int kv_get_high_voltage_limit(struct radeon_device *rdev, int *limit) &rdev->pm.dpm.dyn_state.vddc_dependency_on_sclk; int i; - if (table && table->count) { + if (table->count) { for (i = table->count - 1; i >= 0; i--) { if (pi->high_voltage_t && (kv_convert_8bit_index_to_voltage(rdev, table->entries[i].v) <= @@ -2149,7 +2149,7 @@ static void kv_init_graphics_levels(struct radeon_device *rdev) struct radeon_clock_voltage_dependency_table *table = &rdev->pm.dpm.dyn_state.vddc_dependency_on_sclk; - if (table && table->count) { + if (table->count) { u32 vid_2bit; pi->graphics_dpm_level_count = 0;