From patchwork Mon May 15 07:21:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13240902 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35A7AC77B75 for ; Mon, 15 May 2023 07:21:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0103C10E15C; Mon, 15 May 2023 07:21:45 +0000 (UTC) Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0EB6910E15A for ; Mon, 15 May 2023 07:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1684135302; x=1715671302; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=M6VMANjjtOb3fSFKZxV/mbWcifazyrEVC8AZCALd/DY=; b=HTKKS3FbTYTh1beV/dYdDxhwcnvhJeGJSegHY4FJXvEcC8vTwIlAzeos 9LZa04bya32i5s5D84jKzEvmH9K6SlhsKGEQHph116uDWWvxoDxXFRb41 JotS+5JDBGWfVGL0OQd3DIAVYmRbf9uopqqQ3B/W9S1SGSGZ6sAWNkWEj sFqZgMiTFn/4bK2HhlgvsrpsZNHLaNZrVQGGHpvOxygeLL7L9fB8Iu+0U gPBX2SXfOCNh9ccf0EAHE2RffC5vw9GQrQ01XMmeOPU9NqENORcDpnrgX eQaA4hPZGRiGNxF6X6s7xgdywxT7+pMRHWL+m/2AJ4THqpR4p2DRmgO6A Q==; X-IronPort-AV: E=Sophos;i="5.99,275,1677538800"; d="scan'208";a="30898473" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 15 May 2023 09:21:39 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Mon, 15 May 2023 09:21:39 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Mon, 15 May 2023 09:21:39 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1684135299; x=1715671299; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=M6VMANjjtOb3fSFKZxV/mbWcifazyrEVC8AZCALd/DY=; b=nZloOe+T7RwCM85eSQFIpipcoFnMf1qzvMd9Z6xRDtuBbxr133Qwoigh 3RJROT/xhNb8sbIIXS+NsZGxouq5UI4683nRd92aXTECpnbt/qzGp9Mmz EeFCigLizQFjVqQIMptkiCC6TD+Rouo+SfRnWNnvB9sfN3jUdMzbQ+JWj SjYWC4eY4rFdp4qnwfbE0JP5p+k8DxN22BB59iyD7tQ4yXbRfYX0/5UWn N/MyRg4FpB4owxp2SRdUXpY9SqKcfvkjszgQndL5SFvSjMJxPJHs1ZrJl 6J0o6WNEoFI3jFOj2JwbM5jAZ7oX2PUUYtdEgmnalqxEJ+06kf6h5tiHP w==; X-IronPort-AV: E=Sophos;i="5.99,275,1677538800"; d="scan'208";a="30898472" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 15 May 2023 09:21:39 +0200 Received: from steina-w.tq-net.de (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 68AF9280056; Mon, 15 May 2023 09:21:39 +0200 (CEST) From: Alexander Stein To: Philipp Zabel , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Fabio Estevam , Sebastian Reichel Subject: [PATCH v2 1/1] drm/imx/ipuv-v3: Fix front porch adjustment upon hactive aligning Date: Mon, 15 May 2023 09:21:37 +0200 Message-Id: <20230515072137.116211-1-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexander Stein , dri-devel@lists.freedesktop.org, NXP Linux Team , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" When hactive is not aligned to 8 pixels, it is aligned accordingly and hfront porch needs to be reduced the same amount. Unfortunately the front porch is set to the difference rather than reducing it. There are some Samsung TVs which can't cope with a front porch of instead of 70. Fixes: 94dfec48fca7 ("drm/imx: Add 8 pixel alignment fix") Signed-off-by: Alexander Stein --- Changes in v2: * Rebased to next-2030515 drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c b/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c index 5f26090b0c98..89585b31b985 100644 --- a/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c +++ b/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c @@ -310,7 +310,7 @@ static void ipu_crtc_mode_set_nofb(struct drm_crtc *crtc) dev_warn(ipu_crtc->dev, "8-pixel align hactive %d -> %d\n", sig_cfg.mode.hactive, new_hactive); - sig_cfg.mode.hfront_porch = new_hactive - sig_cfg.mode.hactive; + sig_cfg.mode.hfront_porch -= new_hactive - sig_cfg.mode.hactive; sig_cfg.mode.hactive = new_hactive; }