| Message ID | 20230517133112.873856-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/nouveau/acr/ga102: set variable ga102_gsps storage-class-specifier to static | expand |
Reviewed-by: Karol Herbst <kherbst@redhat.com> On Wed, May 17, 2023 at 3:31 PM Tom Rix <trix@redhat.com> wrote: > > smatch reports > drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c:49:1: warning: symbol > 'ga102_gsps' was not declared. Should it be static? > > This variable is only used in its defining file, so it should be static > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c > index 525267412c3e..a3996ceca995 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c > @@ -45,7 +45,7 @@ ga102_gsp_nofw(struct nvkm_gsp *gsp, int ver, const struct nvkm_gsp_fwif *fwif) > return 0; > } > > -struct nvkm_gsp_fwif > +static struct nvkm_gsp_fwif > ga102_gsps[] = { > { -1, ga102_gsp_nofw, &ga102_gsp }, > {} > -- > 2.27.0 >
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c index 525267412c3e..a3996ceca995 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c @@ -45,7 +45,7 @@ ga102_gsp_nofw(struct nvkm_gsp *gsp, int ver, const struct nvkm_gsp_fwif *fwif) return 0; } -struct nvkm_gsp_fwif +static struct nvkm_gsp_fwif ga102_gsps[] = { { -1, ga102_gsp_nofw, &ga102_gsp }, {}
smatch reports drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c:49:1: warning: symbol 'ga102_gsps' was not declared. Should it be static? This variable is only used in its defining file, so it should be static Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)