| Message ID | 20230531053051.3453509-1-Jun.Ma2@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/ttm: Remove redundant code in ttm_tt_init_fields | expand |
[Public] > -----Original Message----- > From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Ma > Jun > Sent: Wednesday, May 31, 2023 1:31 PM > To: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Koenig, > Christian <Christian.Koenig@amd.com> > Cc: Ma, Jun <Jun.Ma2@amd.com> > Subject: [PATCH v2] drm/ttm: Remove redundant code in ttm_tt_init_fields > > Remove redundant assignment code for ttm->caching as it's overwritten > > just a few lines later. Please drop the blank line in above message. With it fixed, the patch is: Reviewed-by: Guchun Chen <guchun.chen@amd.com> Regards, Guchun > v2: > - Update the commit message. > > Signed-off-by: Ma Jun <Jun.Ma2@amd.com> > --- > drivers/gpu/drm/ttm/ttm_tt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c > index 02b812dacc5d..45a44544b656 100644 > --- a/drivers/gpu/drm/ttm/ttm_tt.c > +++ b/drivers/gpu/drm/ttm/ttm_tt.c > @@ -143,7 +143,6 @@ static void ttm_tt_init_fields(struct ttm_tt *ttm, > unsigned long extra_pages) > { > ttm->num_pages = (PAGE_ALIGN(bo->base.size) >> PAGE_SHIFT) + > extra_pages; > - ttm->caching = ttm_cached; > ttm->page_flags = page_flags; > ttm->dma_address = NULL; > ttm->swap_storage = NULL; > -- > 2.34.1
On 5/31/2023 2:20 PM, Chen, Guchun wrote: > [Public] > >> -----Original Message----- >> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Ma >> Jun >> Sent: Wednesday, May 31, 2023 1:31 PM >> To: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Koenig, >> Christian <Christian.Koenig@amd.com> >> Cc: Ma, Jun <Jun.Ma2@amd.com> >> Subject: [PATCH v2] drm/ttm: Remove redundant code in ttm_tt_init_fields >> >> Remove redundant assignment code for ttm->caching as it's overwritten >> >> just a few lines later. > > Please drop the blank line in above message. With it fixed, the patch is: Reviewed-by: Guchun Chen <guchun.chen@amd.com> > Thanks for review. Will fix it when push. Regards, Ma Jun > Regards, > Guchun > >> v2: >> - Update the commit message. >> >> Signed-off-by: Ma Jun <Jun.Ma2@amd.com> >> --- >> drivers/gpu/drm/ttm/ttm_tt.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c >> index 02b812dacc5d..45a44544b656 100644 >> --- a/drivers/gpu/drm/ttm/ttm_tt.c >> +++ b/drivers/gpu/drm/ttm/ttm_tt.c >> @@ -143,7 +143,6 @@ static void ttm_tt_init_fields(struct ttm_tt *ttm, >> unsigned long extra_pages) >> { >> ttm->num_pages = (PAGE_ALIGN(bo->base.size) >> PAGE_SHIFT) + >> extra_pages; >> - ttm->caching = ttm_cached; >> ttm->page_flags = page_flags; >> ttm->dma_address = NULL; >> ttm->swap_storage = NULL; >> -- >> 2.34.1 >
Am 31.05.23 um 08:20 schrieb Chen, Guchun: > [Public] > >> -----Original Message----- >> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Ma >> Jun >> Sent: Wednesday, May 31, 2023 1:31 PM >> To: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Koenig, >> Christian <Christian.Koenig@amd.com> >> Cc: Ma, Jun <Jun.Ma2@amd.com> >> Subject: [PATCH v2] drm/ttm: Remove redundant code in ttm_tt_init_fields >> >> Remove redundant assignment code for ttm->caching as it's overwritten >> >> just a few lines later. > Please drop the blank line in above message. With it fixed, the patch is: Reviewed-by: Guchun Chen <guchun.chen@amd.com> Seconded, I'm going to pick that patch up and submit it to drm-misc-next with the commit message fixed. Regards, Christian. > > Regards, > Guchun > >> v2: >> - Update the commit message. >> >> Signed-off-by: Ma Jun <Jun.Ma2@amd.com> >> --- >> drivers/gpu/drm/ttm/ttm_tt.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c >> index 02b812dacc5d..45a44544b656 100644 >> --- a/drivers/gpu/drm/ttm/ttm_tt.c >> +++ b/drivers/gpu/drm/ttm/ttm_tt.c >> @@ -143,7 +143,6 @@ static void ttm_tt_init_fields(struct ttm_tt *ttm, >> unsigned long extra_pages) >> { >> ttm->num_pages = (PAGE_ALIGN(bo->base.size) >> PAGE_SHIFT) + >> extra_pages; >> - ttm->caching = ttm_cached; >> ttm->page_flags = page_flags; >> ttm->dma_address = NULL; >> ttm->swap_storage = NULL; >> -- >> 2.34.1
On 5/31/2023 4:45 PM, Christian König wrote: > Am 31.05.23 um 08:20 schrieb Chen, Guchun: >> [Public] >> >>> -----Original Message----- >>> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Ma >>> Jun >>> Sent: Wednesday, May 31, 2023 1:31 PM >>> To: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Koenig, >>> Christian <Christian.Koenig@amd.com> >>> Cc: Ma, Jun <Jun.Ma2@amd.com> >>> Subject: [PATCH v2] drm/ttm: Remove redundant code in ttm_tt_init_fields >>> >>> Remove redundant assignment code for ttm->caching as it's overwritten >>> >>> just a few lines later. >> Please drop the blank line in above message. With it fixed, the patch is: Reviewed-by: Guchun Chen <guchun.chen@amd.com> > > Seconded, I'm going to pick that patch up and submit it to drm-misc-next > with the commit message fixed. > Thanks for help. Regards, Ma Jun > Regards, > Christian. > >> >> Regards, >> Guchun >> >>> v2: >>> - Update the commit message. >>> >>> Signed-off-by: Ma Jun <Jun.Ma2@amd.com> >>> --- >>> drivers/gpu/drm/ttm/ttm_tt.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c >>> index 02b812dacc5d..45a44544b656 100644 >>> --- a/drivers/gpu/drm/ttm/ttm_tt.c >>> +++ b/drivers/gpu/drm/ttm/ttm_tt.c >>> @@ -143,7 +143,6 @@ static void ttm_tt_init_fields(struct ttm_tt *ttm, >>> unsigned long extra_pages) >>> { >>> ttm->num_pages = (PAGE_ALIGN(bo->base.size) >> PAGE_SHIFT) + >>> extra_pages; >>> - ttm->caching = ttm_cached; >>> ttm->page_flags = page_flags; >>> ttm->dma_address = NULL; >>> ttm->swap_storage = NULL; >>> -- >>> 2.34.1 >
diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index 02b812dacc5d..45a44544b656 100644 --- a/drivers/gpu/drm/ttm/ttm_tt.c +++ b/drivers/gpu/drm/ttm/ttm_tt.c @@ -143,7 +143,6 @@ static void ttm_tt_init_fields(struct ttm_tt *ttm, unsigned long extra_pages) { ttm->num_pages = (PAGE_ALIGN(bo->base.size) >> PAGE_SHIFT) + extra_pages; - ttm->caching = ttm_cached; ttm->page_flags = page_flags; ttm->dma_address = NULL; ttm->swap_storage = NULL;
Remove redundant assignment code for ttm->caching as it's overwritten just a few lines later. v2: - Update the commit message. Signed-off-by: Ma Jun <Jun.Ma2@amd.com> --- drivers/gpu/drm/ttm/ttm_tt.c | 1 - 1 file changed, 1 deletion(-)