| Message ID | 20230614013011.750598-1-suijingfeng@loongson.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/fbdev-generic: Remove a redundant assignment clause | expand |
Hi Am 14.06.23 um 03:30 schrieb Sui Jingfeng: > The assignment "dst = map;" in the drm_fbdev_generic_damage_blit() function > is redundant because it has already been copied when the call to > drm_client_buffer_vmap() is finished. Therefore, this patch saves a useless > copy. No functional change. Isn't that what we discussed here? https://lore.kernel.org/dri-devel/20230325074636.136833-1-15330273260@189.cn/ Best regards Thomas > > Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> > --- > drivers/gpu/drm/drm_fbdev_generic.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fbdev_generic.c b/drivers/gpu/drm/drm_fbdev_generic.c > index 98ae703848a0..aa6924e3a58c 100644 > --- a/drivers/gpu/drm/drm_fbdev_generic.c > +++ b/drivers/gpu/drm/drm_fbdev_generic.c > @@ -182,7 +182,7 @@ static int drm_fbdev_generic_damage_blit(struct drm_fb_helper *fb_helper, > struct drm_clip_rect *clip) > { > struct drm_client_buffer *buffer = fb_helper->buffer; > - struct iosys_map map, dst; > + struct iosys_map map; > int ret; > > /* > @@ -202,8 +202,7 @@ static int drm_fbdev_generic_damage_blit(struct drm_fb_helper *fb_helper, > if (ret) > goto out; > > - dst = map; > - drm_fbdev_generic_damage_blit_real(fb_helper, clip, &dst); > + drm_fbdev_generic_damage_blit_real(fb_helper, clip, &map); > > drm_client_buffer_vunmap(buffer); >
Hi, On 2023/6/14 13:29, Thomas Zimmermann wrote: > Hi > > Am 14.06.23 um 03:30 schrieb Sui Jingfeng: >> The assignment "dst = map;" in the drm_fbdev_generic_damage_blit() >> function >> is redundant because it has already been copied when the call to >> drm_client_buffer_vmap() is finished. Therefore, this patch saves a >> useless >> copy. No functional change. > > Isn't that what we discussed here? > Yeah, Lucas say he would like to take a deeper look in later time. Then, two and half a mouths passed, it seem that no one send fix patch. I thinks this is an exercise for me, I resend this patch again. Any idea? > https://lore.kernel.org/dri-devel/20230325074636.136833-1-15330273260@189.cn/ > > > Best regards > Thomas > >> >> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> >> --- >> drivers/gpu/drm/drm_fbdev_generic.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_fbdev_generic.c >> b/drivers/gpu/drm/drm_fbdev_generic.c >> index 98ae703848a0..aa6924e3a58c 100644 >> --- a/drivers/gpu/drm/drm_fbdev_generic.c >> +++ b/drivers/gpu/drm/drm_fbdev_generic.c >> @@ -182,7 +182,7 @@ static int drm_fbdev_generic_damage_blit(struct >> drm_fb_helper *fb_helper, >> struct drm_clip_rect *clip) >> { >> struct drm_client_buffer *buffer = fb_helper->buffer; >> - struct iosys_map map, dst; >> + struct iosys_map map; >> int ret; >> /* >> @@ -202,8 +202,7 @@ static int drm_fbdev_generic_damage_blit(struct >> drm_fb_helper *fb_helper, >> if (ret) >> goto out; >> - dst = map; >> - drm_fbdev_generic_damage_blit_real(fb_helper, clip, &dst); >> + drm_fbdev_generic_damage_blit_real(fb_helper, clip, &map); >> drm_client_buffer_vunmap(buffer); >
diff --git a/drivers/gpu/drm/drm_fbdev_generic.c b/drivers/gpu/drm/drm_fbdev_generic.c index 98ae703848a0..aa6924e3a58c 100644 --- a/drivers/gpu/drm/drm_fbdev_generic.c +++ b/drivers/gpu/drm/drm_fbdev_generic.c @@ -182,7 +182,7 @@ static int drm_fbdev_generic_damage_blit(struct drm_fb_helper *fb_helper, struct drm_clip_rect *clip) { struct drm_client_buffer *buffer = fb_helper->buffer; - struct iosys_map map, dst; + struct iosys_map map; int ret; /* @@ -202,8 +202,7 @@ static int drm_fbdev_generic_damage_blit(struct drm_fb_helper *fb_helper, if (ret) goto out; - dst = map; - drm_fbdev_generic_damage_blit_real(fb_helper, clip, &dst); + drm_fbdev_generic_damage_blit_real(fb_helper, clip, &map); drm_client_buffer_vunmap(buffer);
The assignment "dst = map;" in the drm_fbdev_generic_damage_blit() function is redundant because it has already been copied when the call to drm_client_buffer_vmap() is finished. Therefore, this patch saves a useless copy. No functional change. Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> --- drivers/gpu/drm/drm_fbdev_generic.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)