diff mbox series

[v2] drm/panel: simple: Add connector_type for innolux_at043tn24

Message ID 20230620112202.654981-1-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series [v2] drm/panel: simple: Add connector_type for innolux_at043tn24 | expand

Commit Message

Fabio Estevam June 20, 2023, 11:22 a.m. UTC
From: Fabio Estevam <festevam@denx.de>

The innolux at043tn24 display is a parallel LCD. Pass the 'connector_type'
information to avoid the following warning:

panel-simple panel: Specify missing connector_type

Signed-off-by: Fabio Estevam <festevam@denx.de>
Fixes: 41bcceb4de9c ("drm/panel: simple: Add support for Innolux AT043TN24")
---
Changes since v1:
- Pass Fixes tag (Neil).

 drivers/gpu/drm/panel/panel-simple.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Sam Ravnborg June 21, 2023, 5:40 p.m. UTC | #1
On Tue, Jun 20, 2023 at 08:22:02AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The innolux at043tn24 display is a parallel LCD. Pass the 'connector_type'
> information to avoid the following warning:
> 
> panel-simple panel: Specify missing connector_type
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> Fixes: 41bcceb4de9c ("drm/panel: simple: Add support for Innolux AT043TN24")

Looks good.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
I expect someone else to pick it up.

	Sam
> ---
> Changes since v1:
> - Pass Fixes tag (Neil).
> 
>  drivers/gpu/drm/panel/panel-simple.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index a247a0e7c799..7c80528d571e 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2178,6 +2178,7 @@ static const struct panel_desc innolux_at043tn24 = {
>  		.height = 54,
>  	},
>  	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> +	.connector_type = DRM_MODE_CONNECTOR_DPI,
>  	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
>  };
>  
> -- 
> 2.34.1
Neil Armstrong June 22, 2023, 8:04 a.m. UTC | #2
Hi,

On Tue, 20 Jun 2023 08:22:02 -0300, Fabio Estevam wrote:
> The innolux at043tn24 display is a parallel LCD. Pass the 'connector_type'
> information to avoid the following warning:
> 
> panel-simple panel: Specify missing connector_type
> 
> 

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes)

[1/1] drm/panel: simple: Add connector_type for innolux_at043tn24
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=2c56a751845ddfd3078ebe79981aaaa182629163
diff mbox series

Patch

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index a247a0e7c799..7c80528d571e 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2178,6 +2178,7 @@  static const struct panel_desc innolux_at043tn24 = {
 		.height = 54,
 	},
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.connector_type = DRM_MODE_CONNECTOR_DPI,
 	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
 };