From patchwork Thu Jun 22 15:26:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dong, Zhanjun" X-Patchwork-Id: 13289297 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CAF9EB64DA for ; Thu, 22 Jun 2023 15:26:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A48D010E58C; Thu, 22 Jun 2023 15:26:49 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 23AE010E589; Thu, 22 Jun 2023 15:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687447608; x=1718983608; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=MsOHNhkZdw47mpRisnLrelTXF7tLgbhgwW8ZJ6fjMEk=; b=NHBGYTw9cNPL0ge9cxuEAb6Nlj9giTy0qrGKC6m4Oga/zXt89RXD/Iq6 fTWNTEfPHiEoN7O9UUsSHIdQsREvVEat5jCDzATP52XN8rWjMoxW3eTaT FtrPohqDWkv1jh07VhKEWpP8GnCiVIio6uhv1OQs5ssc9JbYW2FYZlUYk wvNRiUz23Tj6GPXyhMrqV3Mk7A5r7PEIH14LI4AUU6/CBNjF1sMByjmTg GOo5B+UusKd5mYHIJctNNLSaQqZPtEukHI9mUbqB6Irjgl254pCPUBrYC dOPtwMtaMygpoborVdbpXHw34qKRLbX1EZH5yIGykCPxtK1VaaRN2Oi6B g==; X-IronPort-AV: E=McAfee;i="6600,9927,10749"; a="340858721" X-IronPort-AV: E=Sophos;i="6.01,149,1684825200"; d="scan'208";a="340858721" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2023 08:26:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10749"; a="1045223063" X-IronPort-AV: E=Sophos;i="6.01,149,1684825200"; d="scan'208";a="1045223063" Received: from guc-pnp-dev-box-1.fm.intel.com ([10.1.27.12]) by fmsmga005.fm.intel.com with ESMTP; 22 Jun 2023 08:26:46 -0700 From: Zhanjun Dong To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH] drm/i915/gt: Remove incorrect hard coded cache coherrency setting Date: Thu, 22 Jun 2023 08:26:44 -0700 Message-Id: <20230622152644.169400-1-zhanjun.dong@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhanjun Dong Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The previouse i915_gem_object_create_internal already set it with proper value before function return. This hard coded setting is incorrect for platforms like MTL, thus need to be removed. Signed-off-by: Zhanjun Dong --- drivers/gpu/drm/i915/gt/intel_timeline.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c index b9640212d659..693d18e14b00 100644 --- a/drivers/gpu/drm/i915/gt/intel_timeline.c +++ b/drivers/gpu/drm/i915/gt/intel_timeline.c @@ -26,8 +26,6 @@ static struct i915_vma *hwsp_alloc(struct intel_gt *gt) if (IS_ERR(obj)) return ERR_CAST(obj); - i915_gem_object_set_cache_coherency(obj, I915_CACHE_LLC); - vma = i915_vma_instance(obj, >->ggtt->vm, NULL); if (IS_ERR(vma)) i915_gem_object_put(obj);