diff mbox series

drm: bridge: samsung-dsim: Initialize ULPS EXIT for i.MX8M DSIM

Message ID 20230709134827.449185-1-marex@denx.de (mailing list archive)
State New, archived
Headers show
Series drm: bridge: samsung-dsim: Initialize ULPS EXIT for i.MX8M DSIM | expand

Commit Message

Marek Vasut July 9, 2023, 1:48 p.m. UTC
The ULPS EXIT is initialized to 0xaf in downstream BSP as well as older
revisions of this patchset, in newer revisions of the DSIM patchset it
was left out and set to 0. Fix it.

Fixes: 4d562c70c4dc ("drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support")
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@gmail.com>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Robert Foss <rfoss@kernel.org>
Cc: dri-devel@lists.freedesktop.org
---
 drivers/gpu/drm/bridge/samsung-dsim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Robert Foss Aug. 11, 2023, 12:27 p.m. UTC | #1
On Sun, 9 Jul 2023 15:48:27 +0200, Marek Vasut wrote:
> The ULPS EXIT is initialized to 0xaf in downstream BSP as well as older
> revisions of this patchset, in newer revisions of the DSIM patchset it
> was left out and set to 0. Fix it.
> 
> 

Applied, thanks!

[1/1] drm: bridge: samsung-dsim: Initialize ULPS EXIT for i.MX8M DSIM
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=192948f6a923



Rob
diff mbox series

Patch

diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index 9b7a00bafeaaa..7d8afbcf56ca4 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -384,7 +384,7 @@  static const unsigned int imx8mm_dsim_reg_values[] = {
 	[RESET_TYPE] = DSIM_SWRST,
 	[PLL_TIMER] = 500,
 	[STOP_STATE_CNT] = 0xf,
-	[PHYCTRL_ULPS_EXIT] = 0,
+	[PHYCTRL_ULPS_EXIT] = DSIM_PHYCTRL_ULPS_EXIT(0xaf),
 	[PHYCTRL_VREG_LP] = 0,
 	[PHYCTRL_SLEW_UP] = 0,
 	[PHYTIMING_LPX] = DSIM_PHYTIMING_LPX(0x06),