From patchwork Tue Jul 11 14:04:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Christian_K=C3=B6nig?= X-Patchwork-Id: 13308786 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 213D8EB64DC for ; Tue, 11 Jul 2023 14:04:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA53410E3A3; Tue, 11 Jul 2023 14:04:24 +0000 (UTC) Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by gabe.freedesktop.org (Postfix) with ESMTPS id BFEC210E3A3 for ; Tue, 11 Jul 2023 14:04:23 +0000 (UTC) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-9928abc11deso724026666b.1 for ; Tue, 11 Jul 2023 07:04:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689084262; x=1691676262; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=igxnjybBl9nRhvD39E9bq9tTp/UCx9mEEqgWgst1jfY=; b=Yuuk+19uhNTOL7XK+v1UqOkEzOlwusBc0HIKFzZ0Km+HrrL7jE3MV1/GwHNCvSnOet 8yFtSKYI9LRfy2q0x5B28JRrepflY7Zvq0GWIOz/FDCQbM0TuAtwOXOsPX4NmiN/m+Zs IabrXgtR1UqPWGpb7KNJUUWWBW9QQdE/sMAzmHqYAGlWlVp0VdeAep1jkp4AC+CKDF7G 4+Pkxi/xWBsosrt25nQYcJPPpJzbrY6SsHbTCha9kGetpGxPfU5e5T6yyQ8XBIJSW1Rq tswbH6dwzdhzOU+uEUzwuL6xsf4Yucm0PeF9afFrIPc4H/C48mqT0o+EBSLYzHK6HmFU trDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689084262; x=1691676262; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=igxnjybBl9nRhvD39E9bq9tTp/UCx9mEEqgWgst1jfY=; b=aJTyHy7J8eTnbPKrGU5k5nP6qPogPbMLvXLho3zWbNo0Z5L7LNWw/lOZPC23QgvMw1 95qvsrDpWt/3uwgrnTfTU/gw0lxIG8g//nKZWJrtwkqpe6sXm5zdoK2o3po/mDIQrkgY jX+SUlpXRh5bnn3U4T5jyHTG9+IFY2+ykzKdTLhbE4U0y+yjDH2HW5e269sFYbzRJ1aw mZhpKNiSgRnmJgnTz4YG/GJvEcw3mTB8jkKrIhqZauJ4vB3aQJypW2V+tS61Zvv0bRQm GRly98+B/gV/ST/agz+qvT5ghg5CUDYiN627dd4pcoZOy2ywxIoa1TQXWTC/4hPU0bNZ 7GMw== X-Gm-Message-State: ABy/qLaLq69cVhIq6gbAWwGRJKoPmjWUeWfaqHO+5QAafQET8tuCF7Tx O8inY51XIbcNA103r8VoV9Xwsweukw8= X-Google-Smtp-Source: APBJJlGuLDME0AvXeNgZg4NtLwvHnoQzxTyFol6ViP1JWSh84R8T7MW8ccoCgLV78CP6ndzmvfotUg== X-Received: by 2002:a17:906:aac6:b0:992:345e:8319 with SMTP id kt6-20020a170906aac600b00992345e8319mr13091593ejb.58.1689084261850; Tue, 11 Jul 2023 07:04:21 -0700 (PDT) Received: from able.fritz.box ([2a00:e180:154b:c600:dcae:ab99:6259:7e2b]) by smtp.gmail.com with ESMTPSA id e18-20020a170906505200b00989257be620sm1199006ejk.200.2023.07.11.07.04.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 07:04:21 -0700 (PDT) From: " =?utf-8?q?Christian_K=C3=B6nig?= " X-Google-Original-From: =?utf-8?q?Christian_K=C3=B6nig?= To: ogabbay@kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2 Date: Tue, 11 Jul 2023 16:04:14 +0200 Message-Id: <20230711140418.3059-2-christian.koenig@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230711140418.3059-1-christian.koenig@amd.com> References: <20230711140418.3059-1-christian.koenig@amd.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" We want to remove per minor debugfs directories. Start by stopping drivers from adding anything inside of those in the mid layer callback. v2: drop it for the accel node as well Signed-off-by: Christian König Tested-by: Stanislaw Gruszka --- drivers/accel/drm_accel.c | 3 --- drivers/gpu/drm/drm_debugfs.c | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/accel/drm_accel.c b/drivers/accel/drm_accel.c index 4a9baf02439e..01edf2c00b5a 100644 --- a/drivers/accel/drm_accel.c +++ b/drivers/accel/drm_accel.c @@ -99,9 +99,6 @@ void accel_debugfs_init(struct drm_minor *minor, int minor_id) drm_debugfs_create_files(accel_debugfs_list, ACCEL_DEBUGFS_ENTRIES, minor->debugfs_root, minor); - - if (dev->driver->debugfs_init) - dev->driver->debugfs_init(minor); } /** diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c index 4855230ba2c6..54376e2400bb 100644 --- a/drivers/gpu/drm/drm_debugfs.c +++ b/drivers/gpu/drm/drm_debugfs.c @@ -242,7 +242,7 @@ int drm_debugfs_init(struct drm_minor *minor, int minor_id, drm_client_debugfs_init(minor); } - if (dev->driver->debugfs_init) + if (dev->driver->debugfs_init && dev->render != minor) dev->driver->debugfs_init(minor); list_for_each_entry_safe(entry, tmp, &dev->debugfs_list, list) {